GNOME Bugzilla – Bug 741808
title-box: Don't flash the location entry between page loads
Last modified: 2016-09-11 03:47:51 UTC
The location entry shouldn't appear when navigating between pages, nor when refreshing the current page.
Created attachment 293130 [details] [review] title-box: Don't flash the location entry between page loads This fixes the distracting flicker when the title box switches from title mode to location entry mode when loading a page.
Review of attachment 293130 [details] [review]: ::: src/ephy-title-box.c @@ -471,3 @@ - !title || *title == '\0') { - ephy_title_box_set_mode (title_box, EPHY_TITLE_BOX_MODE_LOCATION_ENTRY); - return; The idea is that for pages with no title, we show the location entry. This patch breaks that. Open a bugzilla page with an attachment, for example, and click in the attachment. The location entry should be shown, but the title is shown instead.
Created attachment 296308 [details] [review] title-box: Don't flash the location entry between page loads This fixes the distracting flicker when the title box switches from title mode to location entry mode when loading a page.
Created attachment 300531 [details] [review] title-box: Don't flash the location entry between page loads Just fixed a missing type-check cast
Review of attachment 300531 [details] [review]: With this patch it's possible that the URL is displayed in the subtitle before there is a title for the page. More work needed to ensure the subtitle is not set until the title is ready.