GNOME Bugzilla – Bug 714426
Differentiate the unstarred's icon interior from the selection color
Last modified: 2014-01-30 02:02:53 UTC
---- Reported by jim@yorba.org 2012-07-16 18:49:00 -0700 ---- Original Redmine bug id: 5563 Original URL: http://redmine.yorba.org/issues/5563 Searchable id: yorba-bug-5563 Original author: Jim Nelson Original description: When a message is selected, the interior of the unstarred icon is filled with the selection color. This makes it difficult to determine if the message is starred or not. If making the interior white doesn't work with other themes (such as dark ones), perhaps we could modify the icon on-the-fly so its interior is the color of the default background color. Anything so it's not lost in the selection. Related issues: related to geary - 5727: Update conversation list interface (Fixed) ---- Additional Comments From geary-maint@gnome.bugs 2012-09-10 12:43:00 -0700 ---- ### History #### #1 Updated by Jim Nelson over 1 year ago * **Subject** changed from _Don't make unstarred's interior transparent_ to _Differentiate the unstarred's icon interior from the selection color_ #### #2 Updated by Adam Dingle about 1 year ago * **Assignee** set to _Daniel Fore_ Up for discussion. #### #3 Updated by Adam Dingle about 1 year ago * **Assignee** deleted (<strike>_Daniel Fore_</strike>) * **Target version** deleted (<strike>_0.2_</strike>) --- Bug imported by chaz@yorba.org 2013-11-21 20:26 UTC --- This bug was previously known as _bug_ 5563 at http://redmine.yorba.org/show_bug.cgi?id=5563 Unknown version " in product geary. Setting version to "!unspecified". Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Created attachment 266922 [details] [review] symbolic icons without hardcoded gray Geary is using hardcoded gray color for the starred and unread icon. This patch removes the hardcoded color and related helper code. This makes the state (unread / starred) easier to recognize when the conversation is selected. I guess it will also help users using dark themes.
Thanks! We'll review shortly.
Wolfgang, this is quite promising and takes care of a nit that's bugged me for so, so long. Plus I'm quite pleased how this patch reduces lines of code in the process -- fantastic. Two nits come up with this change, however. I feel like the symbolic icons for starred/unread are now too strong. This issue is described in bug #720771. You've done a lot of work on icons and coloration in Geary, could you attack that one? And, now that the icons are properly shaded, could you look at bug #723265? I feel like you're on a roll here... I've committed this to master: 0dcf353