GNOME Bugzilla – Bug 720771
symbolic icons in conversation list are rendered too black
Last modified: 2019-01-15 06:40:14 UTC
Symbolic icons in the UI are being rendered as black. It should look more like the nautilus/gtk sidebar and be a bit gray. This is normally done by the theme through css. In Adwaita: .image { color: @internal_element_color; } Maybe those aren't actually symbolic icons?
Created attachment 264586 [details] how they look now
Created attachment 264587 [details] how they should look
Created attachment 266683 [details] [review] symbolic_icons_fix
(In reply to comment #3) > Created an attachment (id=266683) [details] [review] > symbolic_icons_fix Your patch fixed bug 721759, thanks!
Thanks Wolfgang! Committed to master, commit 9997d8e7 However, I can't close this ticket yet. The sidebar Inbox icon and the toolbar icons are still black, so a bit more work to be done.
Nice to see this landing on git master so quickly. I can have a look at the remaining icons tomorrow.
I had a look at the remaining icons. Using git master everything looks fine on my machine. To be sure, I even tried with a color picker and all have exactly the same color values. bug 713901 seems to be a duplicate of this bug here.
*** Bug 713901 has been marked as a duplicate of this bug. ***
With bug #714426 landed, this issue is now visible in the conversation list as well. I'm not sure what the issue is; it may be that our custom icons aren't suitable for symbolic use.
What do you think about using the icons from the system theme? 'starred-symbolic" and "non-starred-symbolic" are very similar to the current custom icons anyhow. For the unread status we could use "mail-unread-symbolic" and "mail-read-symbolic". The envelopes don't look that strong compared to geary's huge black dot. Attached is a screenshot.
Created attachment 268521 [details] using system icons instead of custom ones
I'd be happy to use system icons to make our life easier. The starred icons look like they would work. The envelope icon ... yeah, I'd be happy to give that a try. Our big concern in the past is the conversation list looking too "busy" with a lot of iconography. However, Eric made a nice chance in the last release so the unstarred/unread icons only appear with a mouse hover. So what I'm saying is, yes, let's try the system icons.
Created attachment 268960 [details] [review] Use symbolic icons from system theme and remove custom ones from repository. Here is a small patch that changes the two icons. I think it is an improvement. Maybe we can try some time to see how other like it..
I agree, let's try these on for size. I've committed to master (w/ some small changes) at 01dfbc07. I'll push it after the system outage is over. However, I now realize the crux of William's issue: it's not the color of the sidebar icons, it's the color of the icons when they're selected. If you look at his attached screenshots, they're not going white when selected (as we're now doing in the conversation list). Looking at the code, even where we're using system symbolic icons this problem exists. I believe the issue is that in order to load them into GtkTreeView we're using a GtkThemeIcon. Is it possible the color issue is due to that? Anyway, Wolfgang, it'd be great if you could look into this problem as well. It seems like you've dug into just about every place Geary uses icons.
Created attachment 269077 [details] [review] set sidebar icons from string not pixbuf You are right Jim. I did not realize that the icons were not changing their color. The attached patch is a huge change to the way geary's sidebar handles icons. Instead of using ThemedIcons and pixbufs, I just set the icon name and let GTK handle the rest. With this approach the icons change their color if they are selected. The color of the symbolic icons exactly matches those in nautilus. Another thing I removed was the code in geary to track the theme. I think GTK does that for us and indeed changing the icon theme on my system results in an immediate in geary. From the look of it, I really like the sidebar now. Unfortunately, the other symbolic icons in the app seem to be a bit darker. What do you think? - Regarding patches in general, what is easier for you: Applying and reviewing patches or would you prefer checking out and possibly merging a branch on github?
Yes, this is right approach and it's great to see the sidebar code get simplified. Great work! I've pushed to master, commit 310df30. Yes, now the other icons seem a bit bold. Looking at Nautilus (not master, however, an older version) it looks like the icons in the toolbar are meant to be dark (like ours) while its sidebar is the lighter grey your patch introduces to Geary. That leaves icons in the conversation list and the conversation viewer. It'd be great if you could tone down the icons in the conversation list. I'm fine with the dark icons in the conversation viewer -- they're sparse and laid out against a big field and not intrusive. If you could do that, I'll commit that patch and we'll close this ticket. Finally! Patches are easier for me, but whatever's convenient is fine. It's the code that counts.
Conversation viewer icons were fixed bu Bug 765516, conversation list will be fixed by Bug 730682, so adding a dep on that.
Resolving as obsolete all bugs that should be resolved by the conversation list redesign (https://bugzilla.gnome.org/show_bug.cgi?id=730682). I'd mark them as a duplicate, but bz won't let me :( Apologies for the noise.