After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723265 - Conversation list doesn't respect selection palette
Conversation list doesn't respect selection palette
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: ux
master
Other Linux
: High normal
: 0.6.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-30 01:56 UTC by Jim Nelson
Modified: 2014-02-10 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch_723265 (4.89 KB, patch)
2014-02-09 23:34 UTC, Wolfgang Steitz 		none Details | Review

Description Jim Nelson 2014-01-30 01:56:33 UTC 
When a conversation is selected in the conversation list, the Participants list (From:) is properly shaded, i.e. with my theme it goes from black to white.  However, the icons, time, subject line, and preview text is not properly shaded.  The icons, time, and preview are gray, the count badge is gray with white text, and the subject line is dark gray.

The icons are being dealt with in bug #714426.  The other text components should respect the selection palette and be shaded appropriately.
Comment 1 Wolfgang Steitz 2014-02-09 23:34:19 UTC 
Created attachment 268613 [details] [review]
patch_723265
Comment 2 Wolfgang Steitz 2014-02-09 23:38:46 UTC 
Time, subject and preview actually changed the color, but DIM_VALUE was so high, that it always resulted in a very similar grey. Reducing DIM_VALUE has the desired effect... For the subject the color attribute was set in a different way. With this patch the color is always set in the same way.
Comment 3 Jim Nelson 2014-02-10 20:02:44 UTC 
Thanks!  The only tweak I made was to how preview text was handled; we want it to be slightly grayed, but when selected it uses the normal dim values to avoid appearing gray against the selection background.

Pushed to master, commit 7bcdd23