After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 71439 - Implement not-wired-up preferences
Implement not-wired-up preferences
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
1.9.x
Other Linux
: Normal blocker
: 2.0.0
Assigned To: Havoc Pennington
Havoc Pennington
: 16172 71338 71340 71341 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-02-14 02:47 UTC by Havoc Pennington
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0



Description Havoc Pennington 2002-02-14 02:47:07 UTC
Including keybindings prefs, font prefs, etc.
Comment 1 Havoc Pennington 2002-02-14 02:48:28 UTC
*** Bug 16172 has been marked as a duplicate of this bug. ***
Comment 2 Havoc Pennington 2002-02-14 03:38:21 UTC
*** Bug 71340 has been marked as a duplicate of this bug. ***
Comment 3 Havoc Pennington 2002-02-14 03:38:39 UTC
*** Bug 71341 has been marked as a duplicate of this bug. ***
Comment 4 Havoc Pennington 2002-02-14 03:45:15 UTC
*** Bug 71338 has been marked as a duplicate of this bug. ***
Comment 5 Luis Villa 2002-02-14 06:34:49 UTC
Throwing this up to blocker; if you don't have time, Havoc, I'll
encourage release team to encourage someone to help out. I just think
it is fairly important that we not regress functionality wise.
Comment 6 Havoc Pennington 2002-02-17 06:24:14 UTC
The remaining prefs are:
 - Effects tab (background image, etc.)
 - Compatibility tab (blocking on libzvt patch sent to       
   gnome-libs-devel)
 - Keybindings tab (blocking on a substantial amount of work)
 - Font selector dialog (tracked separately as #71744)

Effects and compatibility are trivial.
Font selector is discussed in #71744

For keybindings, some initial notes. I think the gconf storage should
be:
  profiles/<profile_name>/keybindings/activate_tab_one
  profiles/<profile_name>/keybindings/activate_tab_two
  profiles/<profile_name>/keybindings/create_new_tab

These should store a string parseable with gtk_accelerator_parse().

A separate file keytable.[hc] should be created with a
TerminalKeyTable object. This object should hash from keybinding names
"activate_tab_one" to keysym/modmask pairs.

TerminalProfile should have a single TERMINAL_SETTING_KEYTABLE 
which changes whenever any keybinding changes. Also, there's 
a TERMINAL_SETTING_DISABLE_ALL_KEYBINDINGS.

Now here is one hard bit. We would ideally hook in to GtkAccelMap and 
the GTK accel system, such that the active shortcuts appear next to
the corresponding menu item, and the crack-laden inplace-key-changing
correctly modifies the gconf settings. This will require some
investigation but I think it can be done.

A UI question: should it be possible to enable the GtkNotebook
PageUp/PageDown shortcuts.

Another UI question: should there be a Tabs menu in the menubar, 
that displays the shortcut for each tab next to the menu item 
for each tab.

Comment 7 Havoc Pennington 2002-02-21 13:50:02 UTC
*** Bug 72113 has been marked as a duplicate of this bug. ***
Comment 8 Havoc Pennington 2002-03-05 03:19:17 UTC
Only remaining is the "reset to defaults" button and "allow invalid
fonts" checkbutton on the compat tab, I think.
Comment 9 Havoc Pennington 2002-03-10 22:52:57 UTC
All done, whew.