After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702041 - winks: Port to 1.0
winks: Port to 1.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal enhancement
: 1.3.1
Assigned To: Andoni Morales
GStreamer Maintainers
Depends on:
Blocks: 599394 659644
 
 
Reported: 2013-06-11 20:28 UTC by Joshua M. Doe
Modified: 2014-03-15 14:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
incomplete port to 1.0 (38.87 KB, patch)
2013-06-11 20:28 UTC, Joshua M. Doe 		none Details | Review
Port wink to 1.0 (36.12 KB, patch)
2014-03-15 12:11 UTC, Andoni Morales 		committed Details | Review

Description Joshua M. Doe 2013-06-11 20:28:17 UTC 
Created attachment 246562 [details] [review]
incomplete port to 1.0

After seeing a few comments/complaints on the mailing list of winks/ksvideosrc not being ported to 1.0, I thought I'd take a stab at it since it could be useful to me for testing purposes. Attached is an incomplete port to 1.0, as my interest dwindled after a few hours:
- YUV caps not supported (search for the TODO)
- Caps negotiation broken (it works with a capsfilter)
- Only tested on a Creative! Live Cam Notebook Pro VF0400, with 320x240 BGR

I likely won't finish this port anytime soon if at all, so anyone else interested please finish it up.
Comment 1 Andoni Morales 2014-03-15 12:11:27 UTC 
Created attachment 271998 [details] [review]
Port wink to 1.0

Port winks to 1.0
Comment 2 Sebastian Dröge (slomo) 2014-03-15 13:22:01 UTC 
Review of attachment 271998 [details] [review]:

Looks good from a short review :) Let's get it in, can't be worse than not having this plugin at all ;)
Comment 3 Andoni Morales 2014-03-15 14:35:17 UTC 
commit 86e96cfdc68de1c7baf64a6f8d7f55a32b9bb276
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Fri Mar 14 18:23:51 2014 +0100

    winks: port to 1.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=702041