GNOME Bugzilla – Bug 684438
Polkit modal prompts should have spinner while checking
Last modified: 2013-05-09 15:38:41 UTC
When a polkit (or other password prompt) is shown, often after the user clicks 'Authenticate' the prompt remains shown for a while if the password is invalid. During this 'checking' state the prompt should reflect this and not remain sensitive. It could: * Disable the controls visibly somehow. and/or * Display a spinner icon animation indicating that processing is occurring. ... or something else altogether, pending designer input.
About hiding the prompt while checking the password: Even if this checking state becomes imperceptibly short (which it is for keyring, and which I think it should be for polkit) then you still want to avoid interleaving multiple prompts somehow. So the prompt shouldn't be hidden while checking, only to redisplay the same prompt less than a second later. In some cases, such as the evolution password prompt (which I'm not sure should be system modal, in any case) the prompt should be hidden because the password checking attempt can take an arbitrarily long time. See bug #684433. Also the Polkit prompt should allow reentering the password. That's a separate bug #684431.
Created attachment 224815 [details] [review] components: Disable prompt buttons while 'checking' password This is a temporary work around for this issue, since it's causing user problems. See bug #682830. While checking a password in either polkit or keyring prompts disable the buttons during the check. This indicates to the user that input is not possible.
Comment on attachment 224815 [details] [review] components: Disable prompt buttons while 'checking' password The patch needs a bit more work (but my git master gnome isn't working today): * Split the patch for polkit and the keyring prompts. * The keyring prompts should support cancellation while 'checking', see bug #678611.
Created attachment 226350 [details] [review] components: Allow cancelling of dialog between prompts Some callers of the keyring prompt keep the dialog up while processing the prompt. Allow the user to cancel the prompt while in this state. This is propagated to the caller, who can cancel the operation in question when this occurs.
Comment on attachment 224815 [details] [review] components: Disable prompt buttons while 'checking' password Implemented needs-work stuff as a separate patch.
Comment on attachment 224815 [details] [review] components: Disable prompt buttons while 'checking' password This patch has been partly done elsewhere, and last loose ends completed by patch on bug #696304.
Created attachment 241724 [details] [review] modalDialog: Show spinner when working Use the same UI concept from the login screen to show spinners when the polkit or keyring dialogs are working
Created attachment 241726 [details] [review] modalDialog: Show spinner when working Use the same UI concept from the login screen to show spinners when the polkit or keyring dialogs are working
Created attachment 241728 [details] [review] modalDialog: Show spinner when working Use the same UI concept from the login screen to show spinners when the polkit or keyring dialogs are working
Review of attachment 241728 [details] [review]: OK. At some point we really should clean up the minute differences between the password dialogs, but that's a cleanup for later.
Should we get these improvements into 3.8.2 ?
Attachment 241728 [details] pushed as 046a1a7 - modalDialog: Show spinner when working