After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615339 - filesystem icons used by nautilus
filesystem icons used by nautilus
Status: RESOLVED OBSOLETE
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: adwaita-icon-theme maintainer(s)
adwaita-icon-theme maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-04-10 05:22 UTC by Matthias Clasen
Modified: 2015-03-13 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthias Clasen 2010-04-10 05:22:49 UTC
I got a Fedora bug about urls dragged to the desktop having very bland icons in F13. Looking closer, nautilus uses the gnome-fs-bookmark icon for these. Looking at the code, I find that nautilus still uses a number of gnome-fs icons:

gnome-fs-bookmark
gnome-fs-bookmark-missing
gnome-fs-executable
gnome-fs-web
gnome-fs-regular

Do these have standard equivalents ? If so, which ? If not, can we get some ?
Comment 1 Lapo Calamandrei 2010-04-10 08:37:12 UTC
Do you know where these icons are used? The names alone doesn't say much to me.
Anyway I'll try to guess:

- gnome-fs-executable: this sounds like application-x-executable
- gnome-fs-web: ? is it a desktop file linking a web url? In this case I'd use the  corresponding mimetype of what is linked with the link emblem overlayed.
- gnome-fs-bookmark, gnome-fs-bookmark-missing: no idea what they are for.
- gnome-fs-regular: is it the regular file icon? It shouldn't be used at all everything have a mimetype no need for a generic one, anyway text-x-generic or text-x-generic-review could be used here.
Comment 2 Matthias Clasen 2010-04-10 17:50:44 UTC
gnome-fs-bookmark seems to be used as the default icon for bookmarks (ie what you create by using Bookmarks>Add Bookmark in a nautilus window, or apparently, also by dragging urls from your browser to the desktop).

gnome-fs-bookmark-missing is used when nautilus thinks the file that a bookmark points to is no longer there.

gnome-fs-web is used in some code that tries to assign icons to  'nautilus links' which seems to be some desktop file variation that nautilus creates for some things. Not really clear to me, would need some input from alex here. And the code looks like it could do with some update, at least for icon names:

‣‧‧‧‧‧‧‧type = g_key_file_get_string (key_file, MAIN_GROUP, "Type", NULL);
‣‧‧‧‧‧‧‧if (g_strcmp0 (type, "Application") == 0) {
‣‧‧‧‧‧‧‧‣‧‧‧‧‧‧‧icon = g_strdup ("gnome-fs-executable");
‣‧‧‧‧‧‧‧} else if (g_strcmp0 (type, "Link") == 0) {
‣‧‧‧‧‧‧‧‣‧‧‧‧‧‧‧icon = g_strdup ("gnome-dev-symlink");
‣‧‧‧‧‧‧‧} else if (g_strcmp0 (type, "FSDevice") == 0) {
‣‧‧‧‧‧‧‧‣‧‧‧‧‧‧‧icon = g_strdup ("gnome-dev-harddisk");
‣‧‧‧‧‧‧‧} else if (g_strcmp0 (type, "Directory") == 0) {
‣‧‧‧‧‧‧‧‣‧‧‧‧‧‧‧icon = g_strdup (NAUTILUS_ICON_FOLDER);
‣‧‧‧‧‧‧‧} else if (g_strcmp0 (type, "Service") == 0 ||
‣‧‧‧‧‧‧‧‣‧‧‧‧‧‧‧   g_strcmp0 (type, "ServiceType") == 0) {
‣‧‧‧‧‧‧‧‣‧‧‧‧‧‧‧icon = g_strdup ("gnome-fs-web");
‣‧‧‧‧‧‧‧} else {
‣‧‧‧‧‧‧‧‣‧‧‧‧‧‧‧icon = g_strdup ("gnome-fs-regular");
‣‧‧‧‧‧‧‧}

Thankfully, NAUTILUS_ICON_FOLDER is just "folder"
Comment 3 Jakub Steiner 2010-04-10 18:55:30 UTC
For the bookmark, we have user-bookmarks. gnome-fs-executable is application-x-executable.

For the case when you drop a URL (gnome-fs-web) I would really expect the icon to be of the target document it is linking to. And ideally it would be a document thumbnail, rather than an icon. The fact it's a link not an actual file would be signified with the emblem-symbolic-link.

When the target is missing, we don't have a generic icon, but there's image-missing which may or may not be appropriate. If we had the thumbnails/target filetype icons in place, I'd suggest to create an emblem-inaccessible to use here.

gnome-fs-regular is another bummer icon. We've been misusing text-x-preview for this which is meant to be used as a base to render a text preview on top of, but apps like Thunar just use it for when the type of a file could not be determined (octet-stream).
Comment 4 Kamil Páral 2010-04-12 07:33:47 UTC
Adding link to Fedora bug for reference: https://bugzilla.redhat.com/show_bug.cgi?id=578528
(you can see the screenshots)
Comment 5 Matthias Clasen 2010-04-12 10:32:00 UTC
Filed nautilus bug 615509 for this.
Comment 6 Hylke Bons 2010-04-23 13:51:57 UTC
(In reply to comment #2)
> gnome-fs-bookmark seems to be used as the default icon for bookmarks (ie what
> you create by using Bookmarks>Add Bookmark in a nautilus window, or apparently,
> also by dragging urls from your browser to the desktop).

We would like to use the mimetype icon + link emblem for these.
I filed a bug against nautilus for this.
Comment 7 Lapo Calamandrei 2012-10-11 14:33:11 UTC
Those this bug makes sense still?
Comment 8 André Klapper 2015-02-11 15:44:59 UTC
Resetting assignee to default to avoid cookie-licking (see bug 744024).

Jimmac: If you actively and realistically plan to work on this, please set yourself as assignee again so this ticket will be shown on top of your user page at https://bugzilla.gnome.org/page.cgi?id=describeuser.html

Thanks!
Comment 9 Jakub Steiner 2015-03-13 17:42:32 UTC
When using Files to draw icons on the desktop, it will correctly pick the mimetype of the icon and use an emblem over it. Specific icon isn't needed anymore.