After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615509 - use standard icons instead of legacy gnome-fs- icons
use standard icons instead of legacy gnome-fs- icons
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: 3.0
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-12 10:31 UTC by Matthias Clasen
Modified: 2011-04-04 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.12 KB, patch)
2010-04-12 10:31 UTC, Matthias Clasen 		reviewed Details | Review

Description Matthias Clasen 2010-04-12 10:31:36 UTC 
Created attachment 158467 [details] [review]
patch

See bug 615339. gnome-icon-theme is dropping a the legacy icon names, and nautilus should switch to using icon names that are guaranteed by the icon naming spec.

The patch I'm attaching deals with part of the problem. For gnome-dev-symlink and gnome-fs-web, the code needs somewhat larger changes that allow us to return an icon+emblem combination.
Comment 1 Cosimo Cecchi 2010-04-12 11:12:20 UTC 
Review of attachment 158467 [details] [review]:

I inlined a comment below; apart from that, the patch looks good to me.
Is it fine to assume the new icon names you used in the patch are available in g-i-t 2.30? Otherwise we might have to wait after we branch gnome-2-30 before committing this.

::: nautilus-2.30.0/libnautilus-private/nautilus-link.c.icon-names
@@ +483,3 @@
 		icon = g_strdup ("gnome-fs-web");
 	} else {
+		icon = g_strdup ("text-x-preview");

AFAICS the comments in the report seem to imply 'text-x-preview' here is misused? Should we use 'text-x-generic' instead?
Comment 2 Jakub Steiner 2010-04-16 23:01:48 UTC 
text-x-preview will come in gnome-icon-theme 2.30.1, ASAP.
Comment 3 Cosimo Cecchi 2011-04-04 21:29:29 UTC 
I pushed to master a refactor of the Netscape DnD code, which fixes this as a side-effect.