After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597756 - [Q1] Remove deprecated GTK+ code
[Q1] Remove deprecated GTK+ code
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 610346 616817 619671 619672 620611 620618 621012 629955 632729
Blocks:
 
 
Reported: 2009-10-08 01:29 UTC by Javier Jardón (IRC: jjardon)
Modified: 2014-07-25 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove GtkAction deprecated functions (6.92 KB, patch)
2009-10-08 01:31 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove GtkCellRenderer deprecated functions (2.59 KB, patch)
2009-10-08 01:31 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove GtkTreeViewColumn deprecated functions (2.08 KB, patch)
2009-10-08 01:32 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove GtkWindow deprecated code (1.05 KB, patch)
2009-10-08 04:00 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove GtkWidget deprecated code (6.54 KB, patch)
2009-10-08 04:01 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove GtkVbbox deprecated code (2.01 KB, patch)
2009-10-08 04:02 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove GtkContainer deprecated code (2.76 KB, patch)
2009-10-08 04:03 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove GtkBbox deprecated code (3.28 KB, patch)
2009-10-08 04:04 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove deprecated code: GtkAccelGroup (707 bytes, patch)
2009-10-08 19:01 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated code: GtkCheckMenuItem (2.03 KB, patch)
2009-10-08 19:03 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated code: GtkAccelLabel (828 bytes, patch)
2009-10-08 19:03 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated code: GtkEntry (9.60 KB, patch)
2009-10-08 19:04 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove deprecated code: GtkLabel (2.67 KB, patch)
2009-10-08 19:04 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated code: GtkPaned (2.01 KB, patch)
2009-10-08 19:05 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated code: GtkRadioButton (904 bytes, patch)
2009-10-08 19:05 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated code: GtkFileChooserButton (1.29 KB, patch)
2009-10-08 19:06 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated code: GtkToolbar (27.27 KB, patch)
2010-05-01 17:18 UTC, Garrett Regier 		committed Details | Review
Remove deprecated code: gtkenum (880 bytes, patch)
2010-05-01 20:30 UTC, Garrett Regier 		committed Details | Review
Remove deprecated code: GtkNotebook (8.31 KB, patch)
2010-05-01 20:30 UTC, Garrett Regier 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-10-08 01:29:41 UTC 
See http://live.gnome.org/GTK+/3.0/Tasks for more info
Comment 1 Javier Jardón (IRC: jjardon) 2009-10-08 01:31:06 UTC 
Created attachment 145007 [details] [review]
Remove GtkAction deprecated functions
Comment 2 Javier Jardón (IRC: jjardon) 2009-10-08 01:31:50 UTC 
Created attachment 145008 [details] [review]
Remove GtkCellRenderer deprecated functions
Comment 3 Javier Jardón (IRC: jjardon) 2009-10-08 01:32:30 UTC 
Created attachment 145009 [details] [review]
Remove GtkTreeViewColumn deprecated functions
Comment 4 Javier Jardón (IRC: jjardon) 2009-10-08 04:00:33 UTC 
Created attachment 145012 [details] [review]
Remove GtkWindow deprecated code
Comment 5 Javier Jardón (IRC: jjardon) 2009-10-08 04:01:21 UTC 
Created attachment 145013 [details] [review]
Remove GtkWidget deprecated code
Comment 6 Javier Jardón (IRC: jjardon) 2009-10-08 04:02:21 UTC 
Created attachment 145014 [details] [review]
Remove GtkVbbox deprecated code
Comment 7 Javier Jardón (IRC: jjardon) 2009-10-08 04:03:37 UTC 
Created attachment 145015 [details] [review]
Remove GtkContainer deprecated code
Comment 8 Javier Jardón (IRC: jjardon) 2009-10-08 04:04:25 UTC 
Created attachment 145016 [details] [review]
Remove GtkBbox deprecated code
Comment 9 Javier Jardón (IRC: jjardon) 2009-10-08 19:01:47 UTC 
Created attachment 145058 [details] [review]
Remove deprecated code: GtkAccelGroup
Comment 10 Javier Jardón (IRC: jjardon) 2009-10-08 19:03:09 UTC 
Created attachment 145059 [details] [review]
Remove deprecated code: GtkCheckMenuItem
Comment 11 Javier Jardón (IRC: jjardon) 2009-10-08 19:03:39 UTC 
Created attachment 145060 [details] [review]
Remove deprecated code: GtkAccelLabel
Comment 12 Javier Jardón (IRC: jjardon) 2009-10-08 19:04:10 UTC 
Created attachment 145061 [details] [review]
Remove deprecated code: GtkEntry
Comment 13 Javier Jardón (IRC: jjardon) 2009-10-08 19:04:49 UTC 
Created attachment 145062 [details] [review]
Remove deprecated code: GtkLabel
Comment 14 Javier Jardón (IRC: jjardon) 2009-10-08 19:05:19 UTC 
Created attachment 145063 [details] [review]
Remove deprecated code: GtkPaned
Comment 15 Javier Jardón (IRC: jjardon) 2009-10-08 19:05:56 UTC 
Created attachment 145064 [details] [review]
Remove deprecated code: GtkRadioButton
Comment 16 Javier Jardón (IRC: jjardon) 2009-10-08 19:06:36 UTC 
Created attachment 145065 [details] [review]
Remove deprecated code: GtkFileChooserButton
Comment 17 Javier Jardón (IRC: jjardon) 2009-10-09 17:07:17 UTC 
Comment on attachment 145059 [details] [review]
Remove deprecated code: GtkCheckMenuItem

commited an improved version of this patch

commit ed4d2e23a3e2945f22bcbc64d338ef9d42b07c1f
Comment 18 Javier Jardón (IRC: jjardon) 2009-10-09 17:12:57 UTC 
Comment on attachment 145060 [details] [review]
Remove deprecated code: GtkAccelLabel

commited an improved version of this patch

commit c7a8445f11f841af6e553476a00abc251ee2ce06
Comment 19 Javier Jardón (IRC: jjardon) 2009-10-09 17:43:27 UTC 
Comment on attachment 145063 [details] [review]
Remove deprecated code: GtkPaned

commited an improved version of this patch

commit 13a25f9528d865a5c689aabe8900c3843be0f267
Comment 20 Javier Jardón (IRC: jjardon) 2009-10-09 17:51:22 UTC 
Comment on attachment 145064 [details] [review]
Remove deprecated code: GtkRadioButton

committed an improved version of this patch

commit http://git.gnome.org/cgit/gtk+/commit/?h=gtk-2.90&id=ab538d9c245b2a5d090cce488359ccc5fd0218eb
Comment 21 Javier Jardón (IRC: jjardon) 2009-10-09 17:54:57 UTC 
Comment on attachment 145065 [details] [review]
Remove deprecated code: GtkFileChooserButton

Committed an improved version of this patch

commit 1115d323d0a4c35554aa6fcb52c36be3423e7c21
Comment 22 Javier Jardón (IRC: jjardon) 2009-10-10 14:28:40 UTC 
Comment on attachment 145065 [details] [review]
Remove deprecated code: GtkFileChooserButton

committed a improved version of this patch

commit 1115d323d0a4c35554aa6fcb52c36be3423e7c21
Comment 23 Javier Jardón (IRC: jjardon) 2009-10-10 14:29:22 UTC 
Comment on attachment 145062 [details] [review]
Remove deprecated code: GtkLabel

committed a improved version of this patch

commit e9d18c5b05d30cdb2efe2f472603050173b43c6a
Comment 24 Javier Jardón (IRC: jjardon) 2009-10-26 14:36:34 UTC 
Comment on attachment 145061 [details] [review]
Remove deprecated code: GtkEntry

Also commited in other commit: http://git.gnome.org/cgit/gtk+/commit/?h=gtk-2-90&id=0b54b52e7405e02d5e33c46697ba6f2f7b6fd9bd
Comment 25 Garrett Regier 2010-05-01 17:18:08 UTC 
Created attachment 160100 [details] [review]
Remove deprecated code: GtkToolbar
Comment 26 Garrett Regier 2010-05-01 20:30:28 UTC 
Created attachment 160117 [details] [review]
Remove deprecated code: gtkenum
Comment 27 Garrett Regier 2010-05-01 20:30:58 UTC 
Created attachment 160118 [details] [review]
Remove deprecated code: GtkNotebook
Comment 28 Matthias Clasen 2010-08-10 04:20:06 UTC 
Review of attachment 160100 [details] [review]:

Looks like this has already been committed.
Comment 29 Matthias Clasen 2010-08-10 04:22:52 UTC 
Review of attachment 160117 [details] [review]:

This looks incomplete:

grep MENU_INTERNALS *.c
gtkmenubar.c:#define GTK_MENU_INTERNALS
gtkmenu.c:#define GTK_MENU_INTERNALS
gtkmenuitem.c:#define GTK_MENU_INTERNALS
gtkmenushell.c:#define GTK_MENU_INTERNALS
Comment 30 Matthias Clasen 2010-08-10 04:24:43 UTC 
Review of attachment 160118 [details] [review]:

The setter/getter have been removed already. I don't think the intention was to remove the child properties themselves. So I consider this done.
Comment 31 Matthias Clasen 2010-10-19 17:39:54 UTC 
Comment on attachment 160100 [details] [review]
Remove deprecated code: GtkToolbar

This is all done, afaics
Comment 32 Matthias Clasen 2010-10-19 17:40:47 UTC 
Comment on attachment 160117 [details] [review]
Remove deprecated code: gtkenum

This is all done, afaics
Comment 33 Javier Jardón (IRC: jjardon) 2011-08-30 11:09:10 UTC 
I reopen this as the problem with GtkButton signals is still not fixed. See bug #632729
Comment 34 Matthias Clasen 2014-07-25 19:39:49 UTC 
closing again, no point in keeping this open