GNOME Bugzilla – Bug 610346
Confusion between GtkWindow:allow-grow and GtkWindow:resizable
Last modified: 2010-07-02 19:57:47 UTC
I can't see any difference between GtkWindow:allow-grow and GtkWindow:resizable. I imagine that they used to be different some time in the past, but right now the code is exactly the same, they both modify window->allow_grow http://git.gnome.org/browse/gtk+/tree/gtk/gtkwindow.c#n1104 http://git.gnome.org/browse/gtk+/tree/gtk/gtkwindow.c#n990 I think that one of them should be marked as deprecated, or at least the documentation should be a bit clearer about this fact.
That is why gtk_window_set_policy is deprecated.
So shouldn't the properties be deprecated too?
Created attachment 163724 [details] [review] Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink
Created attachment 165008 [details] [review] Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v2 Updated patch using proper documentation comments
Created attachment 165009 [details] [review] Remove GtkWindow:allow-grow and GtkWindow::allow_shrink This is for master (GTK+3) only
Review of attachment 165008 [details] [review]: Could we use the new G_PARAM_DEPRECATED flag here ?
Review of attachment 165009 [details] [review]: It might make sense to rename the struct field to resizable too, to match the property name
Created attachment 165122 [details] [review] Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v3 Rename allow_grow -> resizable
Created attachment 165123 [details] [review] Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v3 Use G_PARAM_DEPRECATED
Created attachment 165124 [details] [review] Remove GtkWindow:allow-grow and GtkWindow::allow_shrink.v2 Rename allow_grow -> resizable
Review of attachment 165123 [details] [review]: looks good
Review of attachment 165124 [details] [review]: looks good
Comment on attachment 165123 [details] [review] Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v3 gtk-2-22: commit 3805dc36052d87e4ee8b3e57c9f216671bf59b07 master: commit 1f38a7ac109562b4a2b47b50b7c72c13fd31e0e5
Comment on attachment 165124 [details] [review] Remove GtkWindow:allow-grow and GtkWindow::allow_shrink.v2 commit 1a03a65e36b6288f7854da30bf89b86ad3592726
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.