After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616817 - Remove code to support deprecated GtkToolbar api
Remove code to support deprecated GtkToolbar api
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkToolbar
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 597756
 
 
Reported: 2010-04-26 05:42 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-05-24 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove code to support deprecated GtkToolbar api (25.21 KB, patch)
2010-04-26 05:43 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove code to support deprecated GtkToolbar api.v2 (28.00 KB, patch)
2010-04-29 17:35 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove code to support deprecated GtkToolbar api.v3 (29.42 KB, patch)
2010-05-22 05:22 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-04-26 05:42:56 UTC 
Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-26 05:43:51 UTC 
Created attachment 159569 [details] [review]
Remove code to support deprecated GtkToolbar api
Comment 2 Javier Jardón (IRC: jjardon) 2010-04-29 17:35:26 UTC 
Created attachment 159920 [details] [review]
Remove code to support deprecated GtkToolbar api.v2

A more complete patch: I've also removed GtkToolbarChild.
Comment 3 Javier Jardón (IRC: jjardon) 2010-05-22 05:22:08 UTC 
Created attachment 161697 [details] [review]
Remove code to support deprecated GtkToolbar api.v3

New patch rebased against current master. Also, fix a issue in one test
Comment 4 Matthias Clasen 2010-05-24 03:46:56 UTC 
Comment on attachment 161697 [details] [review]
Remove code to support deprecated GtkToolbar api.v3

Looks ok to me.
Comment 5 Javier Jardón (IRC: jjardon) 2010-05-24 18:27:00 UTC 
Comment on attachment 161697 [details] [review]
Remove code to support deprecated GtkToolbar api.v3

commit cc8dcf738a42ef8c8340bef4c969cd33228bf673
Comment 6 Javier Jardón (IRC: jjardon) 2010-05-24 18:27:37 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thanks Matthias for the review.