After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590647 - use :always-show-image for boomarks/places in menus
use :always-show-image for boomarks/places in menus
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 590652 (view as bug list)
Depends on: 589842
Blocks:
 
 
Reported: 2009-08-03 16:13 UTC by Matthias Clasen
Modified: 2009-08-08 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Always show application icons (3.65 KB, patch)
2009-08-03 18:43 UTC, Marcus Carlson 		committed Details | Review
Adds icons to history and go menu (2.36 KB, patch)
2009-08-03 22:03 UTC, Marcus Carlson 		committed Details | Review
Screenshot of go menu with icons. (30.53 KB, image/png)
2009-08-03 22:04 UTC, Marcus Carlson 		  Details
additional patch for icons in spatial mode (1.75 KB, patch)
2009-08-03 23:12 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2009-08-03 16:13:21 UTC 
We recently switched to not showing icons by default in menus. For some kinds of menuitems, we always want to show icons, including bookmarks and places. To fix this in nautilus, please set the always-show-image property on these menuitems.
Comment 1 A. Walton 2009-08-03 18:36:01 UTC 
*** Bug 590652 has been marked as a duplicate of this bug. ***
Comment 2 Marcus Carlson 2009-08-03 18:43:07 UTC 
Created attachment 139811 [details] [review]
Always show application icons

This patch adds support for always showing the applications icons. Originally posted in bug #546916 (closed).

If I get comments on this I could fix the other entries.
Comment 3 A. Walton 2009-08-03 19:14:53 UTC 
Patch is good, but it only solves the problem in the right-click menu, we still need to add back the icons in Bookmarks & Go.
Comment 4 Marcus Carlson 2009-08-03 19:29:00 UTC 
A. Walton, thanks. I'll try to fix the other ones.
Comment 5 Marcus Carlson 2009-08-03 22:03:45 UTC 
Created attachment 139828 [details] [review]
Adds icons to history and go menu

Adds icons to history and go menu. Not sure if the array is the way to go, if not please comment on how to do it and I'll fix it.
Comment 6 Marcus Carlson 2009-08-03 22:04:49 UTC 
Created attachment 139829 [details]
Screenshot of go menu with icons.
Comment 7 Marcus Carlson 2009-08-03 22:08:33 UTC 
Found a problem with the patch when browsing in spatial mode, the Places menu didn't get the icons. I'll fix it tomorrow.
Comment 8 Matthias Clasen 2009-08-03 23:12:14 UTC 
Created attachment 139831 [details] [review]
additional patch for icons in spatial mode
Comment 9 Cosimo Cecchi 2009-08-03 23:54:06 UTC 
These look good to me.
Comment 10 Robin Stocker 2009-08-04 08:13:31 UTC 
There should be a property on GtkAction to properly fix that (you wouldn't need to use gtk_ui_manager_get_widget), see bug #589842.
Comment 11 Cosimo Cecchi 2009-08-08 13:10:42 UTC 
Committed to master, closing as fixed.