GNOME Bugzilla – Bug 589842
GtkAction API to have its menu item proxies have always-show-image set
Last modified: 2014-05-22 01:23:21 UTC
There should be API (property + accessors) on GtkAction to have its menu item proxies automatically turn on the always-show-image property on the menu item.
Created attachment 140916 [details] [review] patch
The patch is straightforward and looks good to me. I wonder about extending UI manager markup as well, which would let you avoid instantiating actions in code to set the value.
Created attachment 147496 [details] [review] _additional_ patch This patch adds UI manager markup support to always show images in menu items, as suggested in comment 2. It is independent of the previous patch; I'd like for *both* of these ways to set the always-show-image property to be available. There is a tiny problem in that when setting the action's property (from the previous patch) after the menu item is created, the action property overrides the UI manager markup property. It's certainly fixable; just not sure if it matters. As for the previous patch in attachment 140916 [details] [review]: is it ok-to-commit?
Comment on attachment 140916 [details] [review] patch I guess we need to do this
Both committed to master, with Since: tags changed to 2.20 on the first patch. Now for the issue mentioned in comment 3, do we care about this? If we do, I think this can be easily fixed.
Comment on attachment 140916 [details] [review] patch commit e571273d81cc22bd258bfd47b6c53672043ea7da
Comment on attachment 147496 [details] [review] _additional_ patch commit 65485cbc7c8d48513aa7e14477a2eacf82276f9b
closing feature requests for deprecated components