After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546916 - the open with context menu item should use the application icons
the open with context menu item should use the application icons
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.23.x
Other Linux
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 43564 591356 (view as bug list)
Depends on:
Blocks: 590652
 
 
Reported: 2008-08-08 09:54 UTC by Sebastien Bacher
Modified: 2009-08-10 20:03 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Adds application icon to the applications in the open with list (797 bytes, patch)
2009-06-29 19:53 UTC, Marcus Carlson
none Details | Review
Screenshot of open with menu with application icons (68.58 KB, image/png)
2009-06-29 19:54 UTC, Marcus Carlson
  Details
Adds application icon and removes quation marks from the open with list (2.68 KB, patch)
2009-07-07 21:08 UTC, Marcus Carlson
reviewed Details | Review
Always show application icons (3.65 KB, patch)
2009-08-01 15:13 UTC, Marcus Carlson
none Details | Review
Screenshot with icons disabled but app icons still visible (86.99 KB, image/png)
2009-08-01 15:42 UTC, Marcus Carlson
  Details

Description Sebastien Bacher 2008-08-08 09:54:59 UTC
the bug has been opened on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/248008

"when i right click over a menu to select "open with" option, it shows me a folder icon instead of a totem icon or other player program"
Comment 1 abraham 2009-04-17 00:51:56 UTC
this is still happening in gnome 2.26
Comment 2 Cosimo Cecchi 2009-04-27 13:38:14 UTC
Fixed in master.

commit 9c0dddfbaddfe251814ff473d9f0a734c385d931
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date:   Mon Apr 27 15:37:39 2009 +0200

    Display the application icon in the popup menu
    
    If available, display the application icon next to the "Open with"
    item in the file manager window menus (#546916).
Comment 3 abraham 2009-04-27 15:33:14 UTC
thisn is still happening in gnome 2.26
Comment 4 Cosimo Cecchi 2009-04-27 15:40:36 UTC
I just fixed the bug in GIT master some hours ago, so the fix will be available from 2.27.1 on.
Comment 5 abraham 2009-04-27 15:50:37 UTC
can it be a fix for gnome 2.26, in jaunty jackalope?
Comment 6 Sebastien Bacher 2009-06-22 13:37:39 UTC
https://bugs.launchpad.net/bugs/387796 has a similar request for the other entries and the submenu choices
Comment 7 Marcus Carlson 2009-06-29 19:53:35 UTC
Created attachment 137578 [details] [review]
Adds application icon to the applications in the open with list

This patch adds application icons to the other applications in the context menu. See screenshot. Needs review.
Comment 8 Marcus Carlson 2009-06-29 19:54:41 UTC
Created attachment 137579 [details]
Screenshot of open with menu with application icons
Comment 9 Marcus Carlson 2009-07-07 21:08:45 UTC
Created attachment 137999 [details] [review]
Adds application icon and removes quation marks from the open with list

This patch comes from https://bugs.launchpad.net/hundredpapercuts/+bug/394356 where we're happy about these changes and would like them to be included in the next release.
The patch also includes fixes for bug #587533
Comment 10 Cosimo Cecchi 2009-07-08 11:08:09 UTC
Committed a slightly tweaked patch to master for this, thanks.

commit 45c928d3cf112f22d69b25299898301c54d9e961
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date:   Wed Jul 8 12:05:11 2009 +0100

    Use application icons in the context menu
    
    If it's possibile, use the application icons in the open with submenu.
    This also removes quotation marks and useless duplicate "Open With"
    strings from the submenu.
    Patch by Marcus Carlson, fixes bug #587533 and #546916.
Comment 11 Marcus Carlson 2009-08-01 15:13:55 UTC
Created attachment 139691 [details] [review]
Always show application icons

As gnome now switched to no icons in menus (and buttons) I heard [1] application and file icons should still be visible. This patch sets the always show icon to true for "Open" and "Open with" menu entries when it will show an application icon. Is this correct?

[1] I got the feeling for this in http://bugzilla.gnome.org/show_bug.cgi?id=557469
Comment 12 Marcus Carlson 2009-08-01 15:42:19 UTC
Created attachment 139693 [details]
Screenshot with icons disabled but app icons still visible
Comment 13 Matthew Paul Thomas (mpt) 2009-08-03 14:35:24 UTC
Yes, Marcus, that's appropriate. A menu item representing an application should always include the icon for the application, regardless of the icons-in-menus setting.
Comment 14 Matthew Paul Thomas (mpt) 2009-08-03 14:36:26 UTC
*** Bug 43564 has been marked as a duplicate of this bug. ***
Comment 15 Marcus Carlson 2009-08-03 16:28:27 UTC
mpt, any comment on the code? Is it solved correctly?
Comment 16 A. Walton 2009-08-03 19:10:58 UTC
Marking duplicate patch as obsolete, since it's in the other bug now.
Comment 17 A. Walton 2009-08-10 20:03:40 UTC
*** Bug 591356 has been marked as a duplicate of this bug. ***