GNOME Bugzilla – Bug 546916
the open with context menu item should use the application icons
Last modified: 2009-08-10 20:03:40 UTC
the bug has been opened on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/248008 "when i right click over a menu to select "open with" option, it shows me a folder icon instead of a totem icon or other player program"
this is still happening in gnome 2.26
Fixed in master. commit 9c0dddfbaddfe251814ff473d9f0a734c385d931 Author: Cosimo Cecchi <cosimoc@gnome.org> Date: Mon Apr 27 15:37:39 2009 +0200 Display the application icon in the popup menu If available, display the application icon next to the "Open with" item in the file manager window menus (#546916).
thisn is still happening in gnome 2.26
I just fixed the bug in GIT master some hours ago, so the fix will be available from 2.27.1 on.
can it be a fix for gnome 2.26, in jaunty jackalope?
https://bugs.launchpad.net/bugs/387796 has a similar request for the other entries and the submenu choices
Created attachment 137578 [details] [review] Adds application icon to the applications in the open with list This patch adds application icons to the other applications in the context menu. See screenshot. Needs review.
Created attachment 137579 [details] Screenshot of open with menu with application icons
Created attachment 137999 [details] [review] Adds application icon and removes quation marks from the open with list This patch comes from https://bugs.launchpad.net/hundredpapercuts/+bug/394356 where we're happy about these changes and would like them to be included in the next release. The patch also includes fixes for bug #587533
Committed a slightly tweaked patch to master for this, thanks. commit 45c928d3cf112f22d69b25299898301c54d9e961 Author: Cosimo Cecchi <cosimoc@gnome.org> Date: Wed Jul 8 12:05:11 2009 +0100 Use application icons in the context menu If it's possibile, use the application icons in the open with submenu. This also removes quotation marks and useless duplicate "Open With" strings from the submenu. Patch by Marcus Carlson, fixes bug #587533 and #546916.
Created attachment 139691 [details] [review] Always show application icons As gnome now switched to no icons in menus (and buttons) I heard [1] application and file icons should still be visible. This patch sets the always show icon to true for "Open" and "Open with" menu entries when it will show an application icon. Is this correct? [1] I got the feeling for this in http://bugzilla.gnome.org/show_bug.cgi?id=557469
Created attachment 139693 [details] Screenshot with icons disabled but app icons still visible
Yes, Marcus, that's appropriate. A menu item representing an application should always include the icon for the application, regardless of the icons-in-menus setting.
*** Bug 43564 has been marked as a duplicate of this bug. ***
mpt, any comment on the code? Is it solved correctly?
Marking duplicate patch as obsolete, since it's in the other bug now.
*** Bug 591356 has been marked as a duplicate of this bug. ***