GNOME Bugzilla – Bug 584887
Get rid of deprecated libgnome(ui)
Last modified: 2010-01-13 10:43:53 UTC
See http://live.gnome.org/LibgnomeMustDie $ git grep "libgnome" configure.ac: libgnome-2.0 >= $LIBGNOME_REQUIRED \ src/fe-gnome/gui.h:#include <libgnome/gnome-program.h>
$ git grep "libgnomeui" configure.ac: libgnomeui-2.0 >= $LIBGNOMEUI_REQUIRED \ src/fe-gnome/fe-gnome.c:#include <libgnomeui/libgnomeui.h>
__self: src/fe-gnome/fe-gnome.c:101: gui.program = gnome_program_init ( ... src/fe-gnome/util.c:142: path = gnome_program_locate_file (... reference: ToDo * GnomeProgram - easier GOptionContext integration than the current plain gtk interfaces * gnome-util - gnome_program_locate_file wrappers
Created attachment 146887 [details] [review] Replacing libgnome(ui) with EggSMClient and plain Glib/GTK+ A first shot at dropping libgnome(ui) dependency. The patch is huge, but mostly cut-and-paste code from libegg to replace GnomeClient (new subdirectory src/libeggsmclient). I removed the save_session callback from src/fe-gnome/fe-gnome.c, as it didn't do anything apart from setting the restart command, which should be covered by the call to egg_set_desktop_file(). The only call I did not find a suitable replacement for is gnome_accelerators_sync() in src/fe-gnome/fe-gnome.c - in the patch, it is removed without any replacement, which is what various gnome modules I investigated did. I hope that's OK.
Can the last patch please get a review?
Review of attachment 146887 [details] [review]: > gnome_accelerators_sync() in src/fe-gnome/fe-gnome.c Epiphany seem to be using one. Will push this in. http://git.gnome.org/browse/epiphany/commit/?id=659169914fa8da235b35730c688a23c3caca8b3a __self: http://live.gnome.org/SessionManagement/EggSMClient Looks good. Committing.