GNOME Bugzilla – Bug 551511
HIG problems in new xrandr display capplet
Last modified: 2009-02-26 01:32:40 UTC
The new xrandr display capplet has major HIG problems: - the spacings and packings and paddings are wrong all around - mnemonic activation on the combo boxes does not work - wrong capitalisations in the labels (uses title cap., but should use sentense capitalisations) - missing mnemonic on the "Mirror Scrreens" checkbox - missing ":" on some combo boxes' labels - the Help button does nothing - the "Detect Displays" button is way too large Fixing this will require a string freeze break for items 3 - 5.
Created attachment 118384 [details] [review] first patch This patch fixes the dialogue border, and reduces some of the extraneous padding inside the dialogue. (Also #if 0's some unused code so I could build without warnings.) No string changes, and the big button is still there, because I just wanted to get this out of my way before I try to find a better arrangement for it.
Created attachment 119896 [details] [review] Simple patch to reduce the margins Christian's patch is much than this one, but in case you need one small to apply to the 2.24 branch, here is a 3-lines patch that fixes the main problem: margins are far too big.
Thanks, Eric, please commit to the 2.24 branch, Christian, please commit to trunk.
Committed to svn trunk. Not closing the bug since items 3-5 are still outstanding; I'm going to write a patch for them later.
Sorry, I haven't committed my patch to the 2.24 branch because I don't have svn write access. Could someone who has write access do it for me? Thanks (maybe I should ask for write access one day... need to find out how)
(In reply to comment #5) > Sorry, I haven't committed my patch to the 2.24 branch because I don't have svn > write access. Could someone who has write access do it for me? Check patch status. Already happened a while ago. ;-)
I committed a beautification patch for the dialog a while ago; closing this bug :)