After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 499940 - Focus shouldn't go to file list when selecting a bookmark
Focus shouldn't go to file list when selecting a bookmark
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
: 357862 511570 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-11-27 10:40 UTC by Josselin Mouette
Modified: 2008-04-02 17:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtk-filechooser-dont-focus-file-list.diff (1.56 KB, patch)
2008-02-05 23:15 UTC, Federico Mena Quintero
committed Details | Review

Description Josselin Mouette 2007-11-27 10:40:54 UTC
(Originally discussed in bug#148828 with which it is related.)

When browsing in the bookmarks, each time a bookmark is selected, the current folder changes, and the focus goes to the file list. This makes keyboard navigation in the shortcuts awful. (It is still possible to use control+arrows, but this is not the way it should be.)
Comment 1 Federico Mena Quintero 2008-02-05 23:15:47 UTC
Created attachment 104524 [details] [review]
gtk-filechooser-dont-focus-file-list.diff

I've made the file chooser not focus the file list when activating a shortcut.  This makes operation much smoother; as an added benefit, keyboard navigation now works fine in the shortcuts list.

This is committed to both gtk-2-12 and trunk.

2008-02-05  Federico Mena Quintero  <federico@novell.com>

	Don't focus the file list when shortcuts get activated.  This
	removes a lot of ambiguity in when the file selection should
	change, and makes the overall code flow simpler.

	This fixes http://bugzilla.gnome.org/show_bug.cgi?id=419737 -
	file/save dialog clears the filename entry when changing
	directories.

	Also fixes http://bugzilla.gnome.org/show_bug.cgi?id=499940 -
	focus should not go to the file list when a shortcut is activated.

	* gtk/gtkfilechooserdefault.c
	(shortcuts_activate_volume_mount_cb): Don't focus the file list
	(shortcuts_activate_get_info_cb): Likewise.
Comment 2 Federico Mena Quintero 2008-02-26 23:02:18 UTC
*** Bug 357862 has been marked as a duplicate of this bug. ***
Comment 3 Federico Mena Quintero 2008-04-02 17:14:04 UTC
*** Bug 511570 has been marked as a duplicate of this bug. ***