Created attachment 74282 [details] [review]
Patch for Evolution

This patch fixes the following compiler warnings:

e-dialog-utils.c:338: warning: passing argument 1 of 'gtk_file_chooser_set_local_only' from incompatible pointer type
e-dialog-utils.c:427: warning: passing argument 1 of 'gtk_file_chooser_set_local_only' from incompatible pointer type
e-table-header-item.c:1512: warning: passing argument 1 of 'g_object_get_data' from incompatible pointer type
e-table-header-item.c:1515: warning: passing argument 1 of 'gtk_check_menu_item_get_active' from incompatible pointer type
e-table-header-item.c:1525: warning: passing argument 1 of 'gtk_check_menu_item_get_active' from incompatible pointer type
e-table-header-item.c:1556: warning: assignment from incompatible pointer type
e-table-header-item.c:1557: warning: passing argument 1 of 'gtk_widget_show' from incompatible pointer type
e-table-header-item.c:1558: warning: passing argument 1 of 'gtk_menu_item_set_submenu' from incompatible pointer type
e-table-header-item.c:1558: warning: passing argument 2 of 'gtk_menu_item_set_submenu' from incompatible pointer type
e-table-header-item.c:1604: warning: passing argument 1 of 'g_object_set_data' from incompatible pointer type
e-table-header-utils.c:353: warning: passing argument 2 of 'g_object_add_weak_pointer' from incompatible pointer type
e-table-item.c:1675: warning: passing argument 1 of 'g_object_set_data' from incompatible pointer type
e-tree-table-adapter.c:764: warning: passing argument 1 of 'g_idle_add' from incompatible pointer type
e-icon-entry.c:374: warning: passing argument 1 of 'gtk_event_box_set_visible_window' from incompatible pointer type
e-icon-entry.c:379: warning: passing argument 3 of 'g_signal_connect_data' from incompatible pointer type
e-icon-entry.c:380: warning: passing argument 3 of 'g_signal_connect_data' from incompatible pointer type
e-shell-window.c:861: warning: passing argument 1 of ‘store_window_size’ from incompatible pointer type
cal-attachment-select-file.c:85: warning: passing argument 1 of 'gtk_file_chooser_set_local_only' from incompatible pointer type
comp-editor.c:2381: warning: passing argument 2 of 'g_slist_foreach' from incompatible pointer type
delete-comp.c:204: warning: assignment from incompatible pointer type
e-calendar-table.c:1258: warning: passing argument 1 of 'g_object_get_data' from incompatible pointer type
e-day-view.c:7135: warning: assignment from incompatible pointer type
e-day-view.c:7138: warning: assignment from incompatible pointer type
e-meeting-list-view.c:370: warning: initialization from incompatible pointer type
e-week-view.c:2131: warning: passing argument 1 of 'g_object_get_data' from incompatible pointer type
e-week-view.c:2552: warning: passing argument 1 of 'g_object_get_data' from incompatible pointer type
e-week-view.c:2590: warning: assignment from incompatible pointer type
e-week-view.c:2593: warning: assignment from incompatible pointer type
e-week-view.c:3163: warning: assignment from incompatible pointer type
e-week-view.c:3166: warning: assignment from incompatible pointer type
e-tasks.c:562: warning: passing argument 1 of 'g_object_set_data' from incompatible pointer type
gnome-cal.c:1430: warning: return from incompatible pointer type
gnome-cal.c:3447: warning: passing argument 1 of 'e_calendar_table_copy_clipboard' from incompatible pointer type
gnome-cal.c:3465: warning: passing argument 1 of 'e_calendar_table_copy_clipboard' from incompatible pointer type
itip-utils.c:612: warning: assignment from incompatible pointer type
tasks-control.c:255: warning: initialization from incompatible pointer type
e-msg-composer-select-file.c:86: warning: passing argument 1 of 'gtk_file_chooser_set_local_only' from incompatible pointer type
em-account-editor.c:1780: warning: passing argument 1 of 'g_object_get_data' from incompatible pointer type
em-account-editor.c:2628: warning: passing argument 1 of 'g_object_set_data' from incompatible pointer type
em-folder-view.c:564: warning: passing argument 1 of 'em_folder_browser_get_wide' from incompatible pointer type
em-folder-view.c:877: warning: passing argument 1 of '((emfv->preview)->g_class)->format_clone' from incompatible pointer type
em-folder-view.c:877: warning: passing argument 5 of '((emfv->preview)->g_class)->format_clone' from incompatible pointer type
em-folder-view.c:889: warning: passing argument 1 of '((emfv->preview)->g_class)->format_clone' from incompatible pointer type
em-folder-view.c:889: warning: passing argument 5 of '((emfv->preview)->g_class)->format_clone' from incompatible pointer type
em-folder-view.c:1518: warning: passing argument 1 of 'gtk_option_menu_set_history' from incompatible pointer type
em-folder-view.c:1923: warning: assignment from incompatible pointer type
em-format-html-display.c:468: warning: return from incompatible pointer type
em-format-html-display.c:621: warning: passing argument 1 of 'gtk_entry_set_text' from incompatible pointer type
em-format-html-display.c:623: warning: passing argument 1 of 'gtk_signal_emit_by_name' from incompatible pointer type
em-format-html-display.c:630: warning: passing argument 1 of 'gtk_entry_get_text' from incompatible pointer type
em-format-html-display.c:654: warning: passing argument 1 of 'gtk_label_set_mnemonic_widget' from incompatible pointer type
em-format-html-display.c:661: warning: passing argument 3 of 'g_signal_connect_data' from incompatible pointer type
em-format-html-display.c:662: warning: passing argument 3 of 'g_signal_connect_data' from incompatible pointer type
em-format-html-display.c:676: warning: passing argument 1 of 'gtk_button_set_image' from incompatible pointer type
em-format-html-display.c:687: warning: assignment from incompatible pointer type
em-format-html-display.c:707: warning: initialization from incompatible pointer type
em-format-html-display.c:757: warning: passing argument 1 of 'gtk_entry_set_text' from incompatible pointer type
em-format-html-display.c:761: warning: passing argument 1 of 'gtk_signal_emit_by_name' from incompatible pointer type
em-format-html-display.c:771: warning: passing argument 1 of 'efhd_search_destroy' from incompatible pointer type
em-format-html.c:1644: warning: passing argument 1 of 'efh_format_address' from incompatible pointer type
em-mailer-prefs.c:835: warning: passing argument 1 of 'gtk_file_chooser_set_filename' from incompatible pointer type
em-utils.c:394: warning: passing argument 1 of 'gtk_file_chooser_set_local_only' from incompatible pointer type
em-utils.c:802: warning: passing argument 1 of '((ted->emfv->preview)->g_class)->format_clone' from incompatible pointer type
em-utils.c:802: warning: passing argument 5 of '((ted->emfv->preview)->g_class)->format_clone' from incompatible pointer type
em-vfolder-rule.c:421: warning: passing argument 1 of 'gtk_toggle_button_get_active' from incompatible pointer type
em-vfolder-rule.c:424: warning: passing argument 1 of 'gtk_radio_button_get_group' from incompatible pointer type
em-vfolder-rule.c:424: warning: assignment from incompatible pointer type
em-vfolder-rule.c:674: warning: passing argument 1 of 'g_list_nth_data' from incompatible pointer type
em-vfolder-rule.c:675: warning: passing argument 1 of 'gtk_toggle_button_set_active' from incompatible pointer type
em-vfolder-rule.c:676: warning: passing argument 1 of 'gtk_signal_emit_by_name' from incompatible pointer type
mail-ops.c:1833: warning: assignment from incompatible pointer type
mail-send-recv.c:391: warning: passing argument 2 of 'gtk_scrolled_window_add_with_viewport' from incompatible pointer type
message-list.c:1553: warning: passing argument 1 of 'e_cell_hbox_append' from incompatible pointer type
message-list.c:1554: warning: passing argument 1 of 'e_cell_hbox_append' from incompatible pointer type
message-list.c:1555: warning: passing argument 1 of 'e_cell_hbox_append' from incompatible pointer type
message-list.c:1563: warning: passing argument 1 of 'e_cell_vbox_append' from incompatible pointer type
message-list.c:1564: warning: passing argument 1 of 'e_cell_vbox_append' from incompatible pointer type
message-list.c:1566: warning: passing argument 1 of 'g_object_set_data' from incompatible pointer type
message-list.c:1567: warning: passing argument 1 of 'g_object_set_data' from incompatible pointer type
message-list.c:1568: warning: passing argument 1 of 'g_object_set_data' from incompatible pointer type
message-list.c:1578: warning: passing argument 1 of 'g_object_get_data' from incompatible pointer type
message-list.c:1579: warning: passing argument 1 of 'g_object_get_data' from incompatible pointer type
message-list.c:1722: warning: passing argument 1 of 'g_object_set_data' from incompatible pointer type
itip-formatter.c:849: warning: passing argument 2 of 'g_slist_foreach' from incompatible pointer type
gaimbuddies.c:253: warning: passing argument 2 of 'g_file_get_contents' from incompatible pointer type
save-calendar.c:178: warning: passing argument 1 of 'gtk_file_chooser_set_local_only' from incompatible pointer type

Created attachment 74283 [details] [review]
Patch for Evolution-Data-Server

This patch fixes the following compiler warnings:

e-data-server-module.c:273: warning: passing argument 2 of 'g_list_foreach' from incompatible pointer type
camel-imap-store-summary.c:259: warning: passing argument 1 of 'camel_utf8_putc' from incompatible pointer type
camel-imap-store-summary.c:269: warning: passing argument 1 of 'camel_utf8_putc' from incompatible pointer type
camel-imap-store-summary.c:273: warning: passing argument 1 of 'camel_utf8_putc' from incompatible pointer type
camel-nntp-store-summary.c:252: warning: passing argument 1 of 'camel_utf8_putc' from incompatible pointer type
camel-nntp-store-summary.c:262: warning: passing argument 1 of 'camel_utf8_putc' from incompatible pointer type
camel-nntp-store-summary.c:266: warning: passing argument 1 of 'camel_utf8_putc' from incompatible pointer type
camel-groupwise-utils.c:445: warning: assignment from incompatible pointer type
camel-groupwise-utils.c:446: warning: assignment from incompatible pointer type
camel-groupwise-utils.c:668: warning: assignment from incompatible pointer type
camel-groupwise-utils.c:669: warning: assignment from incompatible pointer type
e-name-selector-dialog.c:544: warning: passing argument 2 of 'gtk_label_set_mnemonic_widget' from incompatible pointer type


Note, the following warning is left unfixed because the solution requires non-trivial code changes:

e-cal-backend-caldav.c:1960: warning: passing argument 2 of 'e_cal_backend_notify_object_removed' from incompatible pointer type

There are no "incompatible pointer type" warnings in Evolution-Exchange.

Created attachment 74285 [details] [review]
Patch for GtkHtml

This patch fixes the following compiler warning:

body.c:286: warning: passing argument 1 of 'gtk_widget_get_accessible' from incompatible pointer type

thanks, like always :-)

There's a small typo in attachment #74282 [details] (for Evolution).
GTK_H_BOX should be GTK_HBOX.

Bug #363036 obsoletes the patch for GtkHtml (attachment #74285 [details]).

These patches have been in Fedora for almost six months now with no reported problems.  Committed to Subversion trunk.

Evolution: revision 33339
Evolution-Data-Server: revision 7676