After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 363036 - Fix all compiler warnings
Fix all compiler warnings
Status: RESOLVED OBSOLETE
Product: GtkHtml
Classification: Other
Component: API
3.13.x
Other Linux
: High normal
: ---
Assigned To: gtkhtml-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-10-18 02:49 UTC by Matthew Barnes
Modified: 2007-01-08 10:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Compiler warnings before the patch (23.70 KB, text/plain)
2006-10-18 02:49 UTC, Matthew Barnes 		  Details
Compiler warnings after the patch (7.55 KB, text/plain)
2006-10-18 02:50 UTC, Matthew Barnes 		  Details
Proposed patch (41.79 KB, patch)
2006-10-18 02:52 UTC, Matthew Barnes 		none Details | Review

Description Matthew Barnes 2006-10-18 02:49:00 UTC 
This bug addresses all remaining compiler warnings in GtkHTML.

Well, almost.  There are still several warnings that look something like:

In file included from /usr/include/libbonobo-2.0/bonobo/bonobo-generic-factory.h:16,
                 from /usr/include/libbonobo-2.0/libbonobo.h:36,
                 from /usr/include/libbonoboui-2.0/libbonoboui.h:14,
                 from /usr/include/libbonoboui-2.0/bonobo.h:14,
                 from control-data.h:32,
                 from body.h:27,
                 from body.c:39:
/usr/include/libbonobo-2.0/bonobo/bonobo-i18n.h:47:1: warning: "_" redefined
In file included from body.c:25:
/home/mbarnes/include/glib-2.0/glib/gi18n-lib.h:30:1: warning: this is the location of the previous definition

But I blame this on Bonobo (see bug #363033).
Comment 1 Matthew Barnes 2006-10-18 02:49:53 UTC 
Created attachment 74913 [details]
Compiler warnings before the patch
Comment 2 Matthew Barnes 2006-10-18 02:50:56 UTC 
Created attachment 74914 [details]
Compiler warnings after the patch
Comment 3 Matthew Barnes 2006-10-18 02:52:40 UTC 
Created attachment 74915 [details] [review]
Proposed patch

This patch obsoletes attachment #74285 [details] in bug #360619.
Comment 4 Matthew Barnes 2006-10-18 03:01:20 UTC 
I should also mention that this patch changes the API slightly in components/html-editor/dialog.h.

I ditched the RUN_DIALOG macro and rewrote run_dialog() to take a
(GtkDialog **) instead of a (GtkDialog ***).  Triple-pointers are just silly.
Comment 5 Karsten Bräckelmann 2006-10-23 00:25:42 UTC 
Confirming...
Comment 6 Matthew Barnes 2007-01-08 10:21:39 UTC 
This bug is obsoleted by bug #394182.

Attachment #74915 [details] has been folded into a larger "code cleanup" patch.