GNOME Bugzilla – Bug 360240
Fix "unused variable" compiler warnings
Last modified: 2007-03-16 21:35:40 UTC
I'm attempting to fix compiler warnings by category. "Unused variables" seemed like an easy category to start with for a brain-dead Friday. This bug addresses "unused variable" compiler warnings in the following components: Evolution Evolution-Data-Server Evolution-Exchange GtkHtml
Created attachment 74172 [details] [review] Patch for Evolution This patch fixes the following compiler warnings: e-icon-entry.c:337: warning: unused variable 'box' e-shell-importer.c:278: warning: unused variable ‘entry’ e-contact-print.c:356: warning: unused variable 'page_width' event-page.c:2802: warning: unused variable 'cus_label' memo-editor.c:248: warning: unused variable 'client' memo-editor.c:247: warning: unused variable 'flags' cal-search-bar.c:289: warning: unused variable 'category' cal-search-bar.c:378: warning: unused variable 'l' e-cal-model-tasks.c:1115: warning: unused variable 'set_completed' e-cal-model-tasks.c:1114: warning: unused variable 'prop2' e-day-view-time-item.c:181: warning: unused variable 'cr' e-meeting-list-view.c:571: warning: unused variable 'iter' e-msg-composer-hdrs.c:592: warning: unused variable 'pixmap' e-msg-composer.c:2855: warning: unused variable 'p' e-msg-composer.c:2957: warning: unused variable 'is_image' em-folder-view.c:192: warning: unused variable 'search_bar' em-format-html-display.c:642: warning: unused variable 'label2' em-format-html-display.c:642: warning: unused variable 'image1' em-format-html-display.c:642: warning: unused variable 'alignment' em-format-html-display.c:642: warning: unused variable 'button1' em-format-html-display.c:642: warning: unused variable 'hbox3' em-format-html-display.c:753: warning: unused variable 'toplevel' em-vfolder-rule.c:418: warning: unused variable 'sensitive' em-vfolder-rule.c:617: warning: unused variable 'group' mail-ops.c:1986: warning: unused variable 'fd' message-list.c:1403: warning: unused variable 'sender_name' startup-wizard.c:105: warning: unused variable 'zone'
Created attachment 74175 [details] [review] Patch for Evolution-Data-Server This patch fixes the following compiler warnings: camel-stream-vfs.c:124: warning: unused variable 'result' camel-groupwise-folder.c:1140: warning: unused variable 'attach_list' camel-groupwise-folder.c:1372: warning: unused variable 'attach_list'
Created attachment 74177 [details] [review] Patch for Evolution-Exchange This patch fixes the following compiler warnings: e-book-backend-gal.c:1715: warning: unused variable 'result' e-cal-backend-exchange-calendar.c:1029: warning: unused variable 'cbex' e-cal-backend-exchange-calendar.c:1596: warning: unused variable 'time_rid' e-cal-backend-exchange-calendar.c:1620: warning: unused variable 'old'
There are no "unused variable" warnings in GtkHtml.
Bug #405916 obsoletes the patch for Evolution-Exchange.
Matthew, seems pretty safe to commit. I tried applying and compiling seems OK. Please commit this to trunk. Do compile and see before that :)
I gave the current code base another pass and fixed all the unused variable warnings. Looks like a few more crept in since October. Committed to Subversion trunk. evolution revision 33315 evolution-data-server revision 7658