GNOME Bugzilla – Bug 332605
mail-to-task creates a task blocking the whole task component
Last modified: 2013-09-10 14:04:15 UTC
Distribution: Debian testing/unstable Package: Evolution Severity: blocker Version: GNOME2.12.2 2.4.x Gnome-Distributor: Debian Synopsis: mail-to-task creates a task blocking the whole task component Bugzilla-Product: Evolution Bugzilla-Component: Tasks Bugzilla-Version: 2.4.x Description: Description of Problem: With the plug-in mail-to-task I created a task from a mail. When I switch to the task view and click on the task, evolution starts to run in a loop for hours and can only be killed. Steps to reproduce the problem: 1. restart debian linux and evolution 2. switch to task view 3. click on the task Actual Results: evolution runs in a loop Expected Results: the task description should open How often does this happen? every time Additional Information: The mail was marked as important and had 4 pdf attachments (together about 1 MB). There were are no other tasks. ------- Bug created by bug-buddy at 2006-02-26 10:08 -------
if you start evolution from a shell, is there any valuable output?
started from the terminal in Galeon Evolution works. Also a mail-to-task worked with a mail without an attachment. But this works also with a normal start from within Galeon. Meanwhile I somehow managed to delete the blocking task by deleting the task.ics file. But I don't dare to repeat it with the mail with 4 pdf attachments of together about 800 KB.
I am experiencing the same problem on Ubuntu Dapper with evo 2.6. The mail I converted to a task had a 130k winmail.dat attachment. This is only a problem when trying to open the task from the main Tasks view. From the Calendar view I can open the task succesfully. Package: evolution Priority: optional Section: gnome Installed-Size: 33800 Maintainer: Debian Evolution Maintainers <pkg-evolution-maintainers@lists.alioth.debian.org> Architecture: i386 Version: 2.6.0-0ubuntu3
Reported at https://launchpad.net/distros/ubuntu/+source/evolution/+bug/6393 as well.
confirming as per duplicates.
*** Bug 336506 has been marked as a duplicate of this bug. ***
raising severity and priority, this can block the evolution ui for quite some time.
*** Bug 336577 has been marked as a duplicate of this bug. ***
Created attachment 64262 [details] [review] proposed patch Just drop attachment files.
I think attachment files of mail should be attached in task, but I have no idea where the attachment files store.
Created attachment 64363 [details] [review] revised patch Converting attachment files of mail to task's attachment files.
patch would also fix bug 331698, i assume. adding chen to cc - i'd really love to see this patch (converting attachment files of mail to task's attachment files) reviewed.
The filename of the attachment (camel_mime_part_get_filename (mime_part)) should be checked for special characters as it could be in UTF8 format. Please refer to the function *clean_name* (save-attachments.c) in the save-attachments plugin.
Created attachment 64980 [details] [review] revised patch Thank you for your review. I rewrote my patch as your advice.
Created attachment 64983 [details] [review] update patch Added multipart/alternative handling. I guess this patch also fix bug 335619.
*** Bug 335619 has been marked as a duplicate of this bug. ***
*** Bug 331698 has been marked as a duplicate of this bug. ***
for (i = 0; i < parts; i++) + { + CamelMimePart *mime_part; + CamelContentType *type; + + mime_part = camel_multipart_get_part (CAMEL_MULTIPART (content), i); + type = camel_mime_part_get_content_type (mime_part); The for loop is not necessary here. The first part would be text/plain if its present. So we could as well do it as camel_multipart_get_part (CAMEL_MULTIPART (content), 0); and check if its text/plain before setting the content (just to be safe). Please include the ChangeLog for the patch.
*** Bug 306215 has been marked as a duplicate of this bug. ***
Chenthill, thank you for your kindly advices. I revised my patch like the following: + /* + * Get non-multipart content from multipart message. + */ + while (CAMEL_IS_MULTIPART (content) && count > 0) + { + mime_part = camel_multipart_get_part (CAMEL_MULTIPART (content), 0); + content = camel_medium_get_content_object (CAMEL_MEDIUM (mime_part)); + count--; + } + + type = camel_mime_part_get_content_type (mime_part); + if (!camel_content_type_is (type, "text", "plain")) + return;
Created attachment 65236 [details] [review] revised patch
*** Bug 303641 has been marked as a duplicate of this bug. ***
chen: *poke*! can this patch please go into evo 2.6.2?
*** Bug 306218 has been marked as a duplicate of this bug. ***
Committing the fix and closing the bug as the patch resolves the issue. Chen: You told me you have some suggestions to the above patch. Can you post an updated patch for review and reopen the bug if necessary.
*** Bug 301075 has been marked as a duplicate of this bug. ***