After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319845 - window selector applet has wrong background w/ clearlooks
window selector applet has wrong background w/ clearlooks
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: clearlooks
2.6.x
Other Linux
: Normal trivial
: ---
Assigned To: Richard Stellingwerff
gtk-engines maintainers
: 325087 350542 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-10-26 12:34 UTC by Akos Ladanyi
Modified: 2006-08-09 15:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
fix (726 bytes, patch)
2006-08-08 21:14 UTC, Benjamin Otte (Company)
none Details | Review

Description Akos Ladanyi 2005-10-26 12:34:59 UTC
Distribution/Version: Gentoo 2005.1

1. add the window selector applet to the panel
2. change the theme to clearlooks

The window selector has a gradient in the background, while other applets have a
plain background (like the panel).
Comment 1 Vincent Untz 2005-12-29 18:54:21 UTC
Ryan: if you have some time to look at this nice background bug... ;-)
Comment 2 Vincent Untz 2005-12-31 12:35:21 UTC
*** Bug 325087 has been marked as a duplicate of this bug. ***
Comment 3 Allison Karlitskaya (desrt) 2005-12-31 20:21:26 UTC
The gradient is how clearlooks draws menus.  Window selector is a menu.  For a test, place it next to your applications/places/system menu and see that they're drawn exactly the same way.

of note: on transparent panels both of these widgets have solid black background (this is clearlooks bug 319815)

pretty sure there's nothing that can be done here.... this is just how clearlooks works.
Comment 4 Crispin Flowerday (not receiving bugmail) 2005-12-31 20:55:53 UTC
Well... The volume applet manages just fine, and that is just an icon and a menu, so clearly there is some way of making it work ok.
Comment 5 Allison Karlitskaya (desrt) 2005-12-31 21:44:28 UTC
The volume applet isn't made out of a menu.  It's made out of 100% pure evil.
Comment 6 Allison Karlitskaya (desrt) 2005-12-31 22:35:52 UTC
Seriously though... in order to fix it in a way similar to what you're suggesting you'd have to do something like creating a popup menu on left-click (similar to what some of the other applets/notification-icons do on right click).

This seems like a hack.
Comment 7 Christian Lohmaier 2006-03-11 20:03:00 UTC
my 0,02 €

As an user I don't care how an applet in the panel is realized - I don't even care whether it is called applet or something different.

I just notice that there is a visual glitch compared to the other elements of the panel, mainly the clock, the menu, the volume control.
Other applets (keyboard indicator, network-indicator, drawer, tomboy, notification-area-stuff): all have "flat" look, although you can click on it.

see http://bugzilla.gnome.org/attachment.cgi?id=58769&action=view for a visualization. It makes the panel look ugly.
Comment 8 Benjamin Otte (Company) 2006-08-08 21:14:10 UTC
Created attachment 70515 [details] [review]
fix

It seems a cleanup was messed up a week ago and this bug was already fixed.

I'm not committing this directly because it seems currently no menubar BUT the one in the panel will have a gradient and I have no clue what this means wrt UI freeze.
Comment 9 Vincent Untz 2006-08-08 22:47:35 UTC
I don't think UI freeze is an issue here since we're not promoting transparent panels anywhere (and even if we did, we'd want this to work).
Comment 10 Benjamin Berg 2006-08-09 12:05:55 UTC
*** Bug 350542 has been marked as a duplicate of this bug. ***
Comment 11 Wouter Bolsterlee (uws) 2006-08-09 12:49:39 UTC
Confirming the patch fixes the issue mentioned in bug #350542 (also see screenshot over there). Please commit so that it can be shipped in Gnome 2.16!
Comment 12 Andrew Johnson 2006-08-09 13:44:31 UTC
Actually, I fixed this yesterday as soon as I was told about it, and commited it a few hours later. I just forgot to mention it on this bug report. 
Comment 13 Wouter Bolsterlee (uws) 2006-08-09 14:39:35 UTC
So this bug is fixed. Confirming it's in CVS... please put bug numbers in your ChangeLog comments, it helps us human bug trackers a lot :)
Comment 14 Andrew Johnson 2006-08-09 15:24:36 UTC
I hadn't planned on closing this yet in case because of the UI freeze I had to revert. And I was sure I put it in the changelog.... oops.
Comment 15 Wouter Bolsterlee (uws) 2006-08-09 15:35:09 UTC
I think you're confusing UI freeze with the "hard code freeze" (a few days prior to a release). During UI freeze, bug fixes can be done without approval. You only have to make sure the workings of the user interface don't change. Once again, bug fixes can go in without approval, even when it has minor impact on the UI (eg. an incorrect sensibility check of a checkbox).

During code freeze, things are different. During that period every single commit has to be approved.