After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 128106 - internet radio connection should be asynchronous
internet radio connection should be asynchronous
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: Normal major
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 135515 141397 148160 160024 165993 320479 326162 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-11-28 11:48 UTC by Hakon
Modified: 2006-02-03 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.16 KB, patch)
2006-01-27 12:49 UTC, James "Doc" Livingston 		committed Details | Review

Description Hakon 2003-11-28 11:48:26 UTC 
There should be some information in the status bar when connecting to
internet radio stations. Since it takes some time to hook up, user tends to
ponder "hey what's going on, did I do something wrong?". Also, if there is
net congestion, it is nice to know that is the case, as opposed to
transmission failure studio-side.
At least there is no such info for xine backend.
Comment 1 Colin Walters 2004-02-27 18:43:28 UTC 
*** Bug 135515 has been marked as a duplicate of this bug. ***
Comment 2 Colin Walters 2004-04-30 23:45:25 UTC 
*** Bug 141397 has been marked as a duplicate of this bug. ***
Comment 3 Colin Walters 2004-09-10 06:45:30 UTC 
*** Bug 148160 has been marked as a duplicate of this bug. ***
Comment 4 Olav Vitters 2005-05-09 19:45:07 UTC 
*** Bug 165993 has been marked as a duplicate of this bug. ***
Comment 5 Sebastien Bacher 2005-06-05 12:10:41 UTC 
*** Bug 160024 has been marked as a duplicate of this bug. ***
Comment 6 James "Doc" Livingston 2005-11-03 02:49:16 UTC 
*** Bug 320479 has been marked as a duplicate of this bug. ***
Comment 7 Baptiste Mille-Mathias 2005-11-03 09:13:55 UTC 
copy me
Comment 8 James "Doc" Livingston 2006-01-08 03:24:38 UTC 
*** Bug 326162 has been marked as a duplicate of this bug. ***
Comment 9 James "Doc" Livingston 2006-01-08 05:36:19 UTC 
With GStreamer 0.10, the process of actually connecting to the stream should be asynchronous. However retrieving the playlist to determine the stream's location isn't.

The totem_pl_parser_parse call in rb_shell_player_open_location needs to be performed asynchronously. This is made non-trivial because there is a chain of functions which want to know whether it was successful. Rather than changing all of that, we might be able to simply return TRUE for iradio, and report errors in the same way as for stream errors.
Comment 10 James "Doc" Livingston 2006-01-27 12:49:42 UTC 
Created attachment 58204 [details] [review]
patch

This runs the playlist parser in a new thread, and makes iradio connection asynchronous (at least on 0.10).
Comment 11 James "Doc" Livingston 2006-02-03 10:30:55 UTC 
Patch committed to cvs, so connecting to a station will not block the UI with GStreamer 0.10.

This would be very difficult to fix with GStreamer 0.8, because state changes are synchronous and it isn't safe to run it in another thread. I'm marking this FIXED since it is for gst 0.10, and it is very doubtful to every get fixed for 0.8. (you can re-open if you really disagree)