After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 124981 - Pager should not activate window when switching to another workspace
Pager should not activate window when switching to another workspace
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
2.4.x
Other All
: Normal minor
: ---
Assigned To: libwnck maintainers
libwnck maintainers
: 121770 126482 144828 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-10-19 17:44 UTC by Manish Singh
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to make window clicked on be activated only if it's part of the current workspace (1.06 KB, patch)
2004-06-23 23:54 UTC, Elijah Newren 		accepted-commit_now Details | Review

Description Manish Singh 2003-10-19 17:44:34 UTC 
When switching to a different workspace, wnck_window_activate is called for
the window whose representation is clicked on. In 2.2, this only happened
if you were not switching workspaces, which is the proper behavior imho.

This behavior was caused by the change referenced in bug #109654, and the
patch in bug #122086 to address other breakage caused by that does not
address this issue.
Comment 1 Andrew Sobala 2003-12-04 16:24:33 UTC 
*** Bug 121770 has been marked as a duplicate of this bug. ***
Comment 2 Steve R. Hastings 2004-02-21 08:38:02 UTC 
I really hope this can get fixed before the next release of GNOME.
Comment 3 Elijah Newren 2004-03-08 17:42:50 UTC 
*** Bug 126482 has been marked as a duplicate of this bug. ***
Comment 4 Elijah Newren 2004-06-23 23:54:24 UTC 
Created attachment 28968 [details] [review]
Patch to make window clicked on be activated only if it's part of the current workspace

This patch does not activate/focus any window if a different workspace is
selected.  The correct choice of window depends on the focus mode
(click/sloppy/mouse) which means that it is a job that should be done by
Metacity.  I will shortly be attaching a patch to bug 120100 that does the
Metacity side of things.  Without that patch, this one still works, but
changing desktops with the pager results in no window being focused (which is
what it does half the time right now anyway...)
Comment 5 Elijah Newren 2004-06-24 16:38:57 UTC 
*** Bug 144828 has been marked as a duplicate of this bug. ***
Comment 6 Havoc Pennington 2004-06-24 18:49:13 UTC 
Comment on attachment 28968 [details] [review]
Patch to make window clicked on be activated only if it's part of the current workspace

yay!
Comment 7 Elijah Newren 2004-06-26 03:06:47 UTC 
Committed.
Comment 8 Elijah Newren 2004-06-26 03:31:52 UTC 
Ooops, I hope it isn't a problem that libwnck hasn't yet branched...