GNOME Bugzilla – Bug 110928
AudioCD view not working
Last modified: 2005-11-03 10:36:47 UTC
AudioCD Views have been removed. The code is slightly out of date, and needs to be updated and reintroduced. Patch to follow.
First need to get monkey-media patched - see http://bugzilla.gnome.org/show_bug.cgi?id=110193
Step 2. Remove internal dependancy on forked monkey-media library (see patch).
Created attachment 15817 [details] [review] Patch to remove the forked monkey-media dependancies
Created attachment 15829 [details] [review] Reinstate the cdaudio view itself.
Above patch reintroduces the audiocd view itself, it 'views', but it don't play, as monkey-media audio cd is broken as well.
Created attachment 15868 [details] This will need to go into /data/node-views, in addition to the patch
reassigned to me. Will look into come post 0.5.0 work. -harshy
*** Bug 98671 has been marked as a duplicate of this bug. ***
*** Bug 113999 has been marked as a duplicate of this bug. ***
*** Bug 101381 has been marked as a duplicate of this bug. ***
*** Bug 99838 has been marked as a duplicate of this bug. ***
Those patches are obsolete.
I read that somebody worked on the AudioCD view, perhaps could it add some comments here to let know about the status of its work.
Created attachment 50475 [details] [review] current state of audio cd work This is a patch against cvs, which includes everything in my audio cd work. It include a) the "removable device" manager and base source, b) the audio cd source c) Jonathan Matthew's rb-player-subtype stuff (which is also used for daap) and d) the ipod source converted to use the removable device base source. The audio cd source works fine to play audio cds, although it doesn't do metadata looked and a heap of other nice things. It works on gstreamer plugins 0.8.10, and probably on 0.8.9 (although I haven't checked this recently). The gstreamer-cdio plugin work best, although gstreamer-cdparanoia mostly works. As I don't have an iPod, I can't check that the converted iPod source works, but it hopefully does. As well as metadata lookup, other things that need doing are: sorting the tracks by track number (not by title), better error handling and a good cleanup.
Thanks Doc for the update. Is this view can be merged in RB 0.9, or this is too early ?
I'm going to be doing some work on this over the next few days, particularly cleaning things up - hopefully it'll be in a bit better shape then.
Created attachment 51071 [details] [review] new patch This is an updated patch, which includes a couple of fixes and renames some things (rb-device-source -> rb-removable-media-source, etc). I haven't renamed the device manager yet, but that shouldn't affect anything apart from a couple of lines in the shell. Unlike the last patch this one actually includes the new files (oops), so it is actually usable.
Much more recent patches (that work on cvs) have been posted to the mailing list, so I'm marking the patch as obsolete.
I've committed the audio-cd support to cvs, so we can finally close this.