Adding keywords to all ui-review bugs in one mass change, sorry for the spam. It
would be very nice if the folks doing UI review stuff would be sure to add
'PATCH' to the bugs that have those. I'm (tentatively) not marking these 'high'
but the release team [having gotten approval from the docs and i18n people]
would like to see these in ASAP on the 2.0.1 branches, so that i18n folks can
start translating at their convenience.

After¦some¦discussion¦with¦the¦release¦team,¦in¦order¦to¦get¦these¦in¦to¦2.0.1
and¦to¦not¦make¦the¦translators¦shoot¦us,¦these¦need¦to¦get¦in¦ASAP¦:)¦I'm
marking¦them¦'urgent'/2.0.1¦as¦a¦result;¦it¦would¦be¦greatly¦appreciated¦if
maintainers¦of¦the¦affected¦components¦can¦work¦on¦getting¦these¦patched¦ASAP¦so
that¦the¦translators¦can¦get¦cracking¦on¦them¦for¦the¦next¦release.¦[Subject,¦of
course,¦to¦maintainer¦agreement¦with¦the¦goals¦of¦the¦review¦:)¦

[Search for 'luis spamming' to catch every instance of this email.]
In order to better track Sun's bugs for Sun and Ximian's internal use, I've
added a temporary keyword to some bugs. I apologize for the spam, and for the
use of an additional keyword, but this is the best way for Sun to track 'it's'
bugs without interfering with the community's own triage and bug behavior. If
you have any questions or objections, please drop me a note at louie@ximian.com
or email bugmaster@gnome.org for more open discussion.

For the icon Calum says we should use the stock delete icon.

Created attachment 9721 [details] [review]
patch to fix it

Unfortunately I had to create the dialog by hand to add the Delete icon
to the button and sort out the default button.

I changed it to be non-modal, though I'm not sure if we want to do that.
There was a big comment about why it was modal, but I'm not sure if it
is still relevant. (You can see it in the patch.)

Hmm, I guess if the reasons in the comment for making it modal still
apply then we ought to leave it modal.  I'd guess it's fairly unlikely
that the user will select 'Empty Trash' and then wander off and do
something else before they've confirmed anyway... and if they did want
to, having to click an extra button first isn't really going to hurt.

Created attachment 9783 [details] [review]
Revised patch, with modal dialog again

There were problems with the non-modal dialog because the parent view
could be destroyed, so I switched back to modal.

Hmmm. Perhaps the dialog creation should be split out into a separate
function in eel.

I don't know. The dialog isn't a very general one.

Or did you mean the button creation code? Yes, that would make a
useful utility function.
How about eel_gtk_button_new_with_stock_icon () ?
It would do most of this, except setting CAN_DEFAULT and showing
the button.

+
button = gtk_button_new ();
+
GTK_WIDGET_SET_FLAGS (button, GTK_CAN_DEFAULT);
+
label = gtk_label_new_with_mnemonic (_("_Empty"));
+
gtk_label_set_mnemonic_widget (GTK_LABEL (label), GTK_WIDGET (button));
+
image = gtk_image_new_from_stock (GTK_STOCK_DELETE,
+
				  GTK_ICON_SIZE_BUTTON);
+
hbox = gtk_hbox_new (FALSE, 2);
+
align = gtk_alignment_new (0.5, 0.5, 0.0, 0.0);
+
gtk_box_pack_start (GTK_BOX (hbox), image, FALSE, FALSE, 0);
+
gtk_box_pack_end (GTK_BOX (hbox), label, FALSE, FALSE, 0);
+
gtk_container_add (GTK_CONTAINER (button), align);
+
gtk_container_add (GTK_CONTAINER (align), hbox);
+
gtk_widget_show_all (button);

Created attachment 9816 [details] [review]
patch to add eel_gtk_button_new_with_stock_icon() to eel

Created attachment 9817 [details] [review]
New nautilus patch using new eel function

Looks good. Please commit.

Patch applied, but didn't make it non-modal.
Leaving open for docs people.

This change doesn't require any changes to the User Guide docs.

Closed.