GNOME Bugzilla – Bug 85658
[ui-review][doc] Properties dialog string changes
Last modified: 2004-12-22 21:47:04 UTC
The following issues came out of the recent ui-review and are recommended for fixing prior to GNOME 2.0.1: - Text field on basic tab needs a label, suggestion was _Name - Items on 'Permissions' tab should have mnemonics - s/Number View/Number view - s/Last Changed/Last changed
bug 82707 has the complete ui review attached to it. please add dependencies to that bug.
Adding keywords to all ui-review bugs in one mass change, sorry for the spam. It would be very nice if the folks doing UI review stuff would be sure to add 'PATCH' to the bugs that have those. I'm (tentatively) not marking these 'high' but the release team [having gotten approval from the docs and i18n people] would like to see these in ASAP on the 2.0.1 branches, so that i18n folks can start translating at their convenience.
After¦some¦discussion¦with¦the¦release¦team,¦in¦order¦to¦get¦these¦in¦to¦2.0.1 and¦to¦not¦make¦the¦translators¦shoot¦us,¦these¦need¦to¦get¦in¦ASAP¦:)¦I'm marking¦them¦'urgent'/2.0.1¦as¦a¦result;¦it¦would¦be¦greatly¦appreciated¦if maintainers¦of¦the¦affected¦components¦can¦work¦on¦getting¦these¦patched¦ASAP¦so that¦the¦translators¦can¦get¦cracking¦on¦them¦for¦the¦next¦release.¦[Subject,¦of course,¦to¦maintainer¦agreement¦with¦the¦goals¦of¦the¦review¦:)¦
[Search for 'luis spamming' to catch every instance of this email.] In order to better track Sun's bugs for Sun and Ximian's internal use, I've added a temporary keyword to some bugs. I apologize for the spam, and for the use of an additional keyword, but this is the best way for Sun to track 'it's' bugs without interfering with the community's own triage and bug behavior. If you have any questions or objections, please drop me a note at louie@ximian.com or email bugmaster@gnome.org for more open discussion.
Some comments: - s/Number View/Number view - s/Last Changed/Last changed Why change only these 2? What about "Text View", "Special Flags", "File Owner", "File Group", and "MIME Type" on the Basic page?
Have no idea why that particular control was flagged... you're quite right, all the controls you mention should have their labels in sentence caps. Go ahead and fix them all, please :)
Created attachment 9719 [details] [review] patch to fix it
The patch adds a _Name label next to the filename. That needed a little rearranging of code to set up the mnemonic. (Oops, I just realized I forgot the colon at the end, but I'll add that.) The other main change is to the permission checkboxes. They didn't have labels, which meant they didn't support keynav very well (they didn't show a focus indicator). I placed _Read/_Write/E_xecute labels next to them and removed the title row, so keynav is good now. I'll add a screenshot of this page in a sec.
Created attachment 9720 [details] picture of the permissions page with labels beside checkboxes
Looks pretty good, but could you put the "sticky" checkbox to the right of "Set user id". That may make it look more balanced.
FWIW I think it looks pretty good as it is... except that the "special flags" checkboxes don't *quite* line up with the "Read" checkboxes above, which will probably really bug a lot of people, including me :) Any chance we could fix this?
Created attachment 9779 [details] [review] revised patch to line up checkboxes, and remove old code.
I lined up the checkboxes but I'm afraid it isn't trivial to move the 'Sticky' checkbox as Alex suggested. The current code structure doesn't really support that easily.
Looks good. Please commit.
patch applied. Leaving open for docs people.
jfleck: all yours. :)
adding to Eugene's bugzilla spam
These changes do not affect User Guide docs.