GNOME Bugzilla – Bug 85082
x-unknown charset should use default charset value
Last modified: 2006-06-18 05:15:38 UTC
I tried to get rid of warnings about x-unknown charset and added simple workaround into gmime. x-unknown charset is used by pine, when user did'n set charset. http://www.washington.edu/pine/tech-notes/low-level.html#char-set I put there default charset which I need, it should use default charset from pan instead. I cc'ed this to fejj, it looks like he's author of gmime code. :-) patch: --- gmime-iconv.c.old Tue May 14 05:24:12 2002 +++ gmime-iconv.c Wed Jun 12 22:50:40 2002 @@ -323,6 +323,10 @@ return (iconv_t) -1; } + //replace unknown charset with default + if (!strcasecmp(from, "X-UNKNOWN")) + from = "ISO-8859-2"; + from = g_mime_charset_name (from); to = g_mime_charset_name (to); key = g_alloca (strlen (from) + strlen (to) + 2);
yea, I'll look into fixing this when I get home tonight. hmmm, I should talk to the bug master and see how to add a new module to bugzilla.gnome.org for gmime.
this enhancement should depend on bug #84995
well, not really because gmime is independant of Pan's preferences. The code should be changed to say something along the lines of: if (!strcasecmp (from, "x-unknown")) from = g_mime_charset_locale_name (); possibly allowing the application to override the environment's locale settings...
this is now fixed in gmime
and in pan