After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 84995 - default charset
default charset
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-0.12.0 betas
Other Linux
: Normal enhancement
: 0.12.1
Assigned To: Charles Kerr
Charles Kerr
Depends on:
Blocks:
 
 
Reported: 2002-06-12 09:50 UTC by Martin Tomasek
Modified: 2006-06-18 05:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Martin Tomasek 2002-06-12 09:50:49 UTC 
why is default encoding hardcoded? it would better to have it settable
through preferrences.

I'm currently using this patch to change hardcoded charset:

--- group.c.orig        Sun May 26 01:15:43 2002                          
     
+++ group.c     Wed Jun 12 11:39:53 2002                                  
     
@@ -254,7 +254,7 @@                                                       
     
 const char*                                                              
     
 group_get_default_charset (const Group * group)                          
     
 {                                                                        
     
-       const char * retval = "ISO-8859-1";                               
     
+       const char * retval = "ISO-8859-2";                               
     
                                                                          
     
        g_return_val_if_fail (group_is_valid(group), retval);
Comment 1 Charles Kerr 2002-06-12 16:41:52 UTC 
This would break the string freeze, but will be one of the first
fixes in CVS after 0.12.0 comes out.
Comment 2 Christophe Lambin 2002-06-21 23:26:30 UTC 
Having looked at this, it seems making this a preference seems a
non-trivial task.

(note for charles:  this means libpanbase.a(group.c) would be tied to
the prefs.c module)

What I've done so far is to make the default charset depend on the
user's locale. So a user running with Czech locale would see a default
charset of ISO-8859-2.  

Thoughts ?
Comment 3 Charles Kerr 2002-06-23 04:27:59 UTC 
looks good, remember to check it into cvs head too. :)
Comment 4 Christophe Lambin 2002-06-23 11:30:57 UTC 
Implemented for 0.12.1 and merged to HEAD.