After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653874 - New ATK Roles
New ATK Roles
Status: RESOLVED FIXED
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
pyatspi2 maintainer(s)
Depends on: 651343 653872
Blocks: 638537
 
 
Reported: 2011-07-02 20:59 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2015-02-27 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (3.88 KB, patch)
2011-07-02 22:12 UTC, Joanmarie Diggs (IRC: joanie) 		accepted-commit_now Details | Review
proposed patch - includes ATK version bump (4.29 KB, patch)
2011-07-24 20:13 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2011-07-02 20:59:02 UTC 
+++ This bug was initially created as a clone of Bug #653872 +++

The following roles were agreed upon as being desirable additions to ATK:

* ATK_ROLE_TABLE_ROW
* ATK_ROLE_TREE_ITEM
* ATK_ROLE_DOCUMENT_SPREADSHEET
* ATK_ROLE_DOCUMENT_PRESENTATION
* ATK_ROLE_DOCUMENT_TEXT
* ATK_ROLE_DOCUMENT_WEB
* ATK_ROLE_DOCUMENT_EMAIL
* ATK_ROLE_LIST_BOX
* ATK_ROLE_GROUPING (a group of widgets, can have a title)
* ATK_ROLE_IMAGE_MAP
* ATK_ROLE_NOTIFICATION
* ATK_ROLE_COMMENT (e.g. OOo/LibreOffice Writer or Calc: Insert->Comment)

In addition:

* ATK_ROLE_INFO_BAR

Once these are added to ATK, a corresponding change will need to be made to at-spi2-atk

(End of cloned report)

And they'll of course need to be added to pyatspi2.
Comment 1 Joanmarie Diggs (IRC: joanie) 2011-07-02 22:12:13 UTC 
Created attachment 191170 [details] [review]
proposed patch
Comment 2 Mike Gorse 2011-07-02 22:59:18 UTC 
Comment on attachment 191170 [details] [review]
proposed patch

Looks fine.  Thanks.




>From 69512e6e164b5e4beee681c8be2b1ffa7381397f Mon Sep 17 00:00:00 2001
>From: Joanmarie Diggs <joanmarie.diggs@gmail.com>
>Date: Sat, 2 Jul 2011 17:15:18 -0400
>Subject: [PATCH] Fix for bug 653874 - New ATK Roles
>
>---
> pyatspi/role.py |   43 +++++++++++++++++++++++++++++++++++++++++--
> 1 files changed, 41 insertions(+), 2 deletions(-)
>
>diff --git a/pyatspi/role.py b/pyatspi/role.py
>index 5973b87..fb44a5d 100644
>--- a/pyatspi/role.py
>+++ b/pyatspi/role.py
>@@ -108,7 +108,20 @@ class Role(_Enum):
>                 87:'ROLE_FORM',
>                 88:'ROLE_LINK',
>                 89:'ROLE_INPUT_METHOD_WINDOW',
>-                90:'ROLE_LAST_DEFINED',
>+                90:'ROLE_TABLE_ROW',
>+                91:'ROLE_TREE_ITEM',
>+                92:'ROLE_DOCUMENT_SPREADSHEET',
>+                93:'ROLE_DOCUMENT_PRESENTATION',
>+                94:'ROLE_DOCUMENT_TEXT',
>+                95:'ROLE_DOCUMENT_WEB',
>+                96:'ROLE_DOCUMENT_EMAIL',
>+                97:'ROLE_COMMENT',
>+                98:'ROLE_LIST_BOX',
>+                99:'ROLE_GROUPING',
>+                100:'ROLE_IMAGE_MAP',
>+                101:'ROLE_NOTIFICATION',
>+                102:'ROLE_INFO_BAR',
>+                103:'ROLE_LAST_DEFINED',
>         }
> 
> ROLE_ACCELERATOR_LABEL = Role(1)
>@@ -126,13 +139,19 @@ ROLE_CHECK_MENU_ITEM = Role(8)
> ROLE_COLOR_CHOOSER = Role(9)
> ROLE_COLUMN_HEADER = Role(10)
> ROLE_COMBO_BOX = Role(11)
>+ROLE_COMMENT = Role(97)
> ROLE_DATE_EDITOR = Role(12)
> ROLE_DESKTOP_FRAME = Role(14)
> ROLE_DESKTOP_ICON = Role(13)
> ROLE_DIAL = Role(15)
> ROLE_DIALOG = Role(16)
> ROLE_DIRECTORY_PANE = Role(17)
>+ROLE_DOCUMENT_EMAIL = Role(96)
> ROLE_DOCUMENT_FRAME = Role(82)
>+ROLE_DOCUMENT_PRESENTATION = Role(93)
>+ROLE_DOCUMENT_SPREADSHEET = Role(92)
>+ROLE_DOCUMENT_TEXT = Role(94)
>+ROLE_DOCUMENT_WEB = Role(95)
> ROLE_DRAWING_AREA = Role(18)
> ROLE_EDITBAR = Role(77)
> ROLE_EMBEDDED = Role(78)
>@@ -146,23 +165,28 @@ ROLE_FOOTER = Role(72)
> ROLE_FORM = Role(87)
> ROLE_FRAME = Role(23)
> ROLE_GLASS_PANE = Role(24)
>+ROLE_GROUPING = Role(99)
> ROLE_HEADER = Role(71)
> ROLE_HEADING = Role(83)
> ROLE_HTML_CONTAINER = Role(25)
> ROLE_ICON = Role(26)
> ROLE_IMAGE = Role(27)
>+ROLE_IMAGE_MAP = Role(100)
>+ROLE_INFO_BAR = Role(102)
> ROLE_INPUT_METHOD_WINDOW = Role(89)
> ROLE_INTERNAL_FRAME = Role(28)
> ROLE_INVALID = Role(0)
> ROLE_LABEL = Role(29)
>-ROLE_LAST_DEFINED = Role(90)
>+ROLE_LAST_DEFINED = Role(103)
> ROLE_LAYERED_PANE = Role(30)
> ROLE_LINK = Role(88)
> ROLE_LIST = Role(31)
>+ROLE_LIST_BOX = Role(98)
> ROLE_LIST_ITEM = Role(32)
> ROLE_MENU = Role(33)
> ROLE_MENU_BAR = Role(34)
> ROLE_MENU_ITEM = Role(35)
>+ROLE_NOTIFICATION = Role(101)
> ROLE_OPTION_PANE = Role(36)
> ROLE_PAGE = Role(84)
> ROLE_PAGE_TAB = Role(37)
>@@ -190,6 +214,7 @@ ROLE_STATUS_BAR = Role(54)
> ROLE_TABLE = Role(55)
> ROLE_TABLE_CELL = Role(56)
> ROLE_TABLE_COLUMN_HEADER = Role(57)
>+ROLE_TABLE_ROW = Role(90)
> ROLE_TABLE_ROW_HEADER = Role(58)
> ROLE_TEAROFF_MENU_ITEM = Role(59)
> ROLE_TERMINAL = Role(60)
>@@ -198,6 +223,7 @@ ROLE_TOGGLE_BUTTON = Role(62)
> ROLE_TOOL_BAR = Role(63)
> ROLE_TOOL_TIP = Role(64)
> ROLE_TREE = Role(65)
>+ROLE_TREE_ITEM = Role(91)
> ROLE_TREE_TABLE = Role(66)
> ROLE_UNKNOWN = Role(67)
> ROLE_VIEWPORT = Role(68)
>@@ -292,6 +318,19 @@ ROLE_NAMES = {
>         ROLE_FORM:'form',
>         ROLE_LINK:'link',
>         ROLE_INPUT_METHOD_WINDOW:'input method window',
>+        ROLE_TABLE_ROW:'table row',
>+        ROLE_TREE_ITEM:'tree item',
>+        ROLE_DOCUMENT_SPREADSHEET:'document spreadsheet',
>+        ROLE_DOCUMENT_PRESENTATION:'document presentation',
>+        ROLE_DOCUMENT_TEXT:'document text',
>+        ROLE_DOCUMENT_WEB:'document web',
>+        ROLE_DOCUMENT_EMAIL:'document email',
>+        ROLE_COMMENT:'comment',
>+        ROLE_LIST_BOX:'list box',
>+        ROLE_GROUPING:'grouping',
>+        ROLE_IMAGE_MAP:'image map',
>+        ROLE_NOTIFICATION:'notification',
>+        ROLE_INFO_BAR:'info bar',
> }
> 
> #END----------------------------------------------------------------------------
>-- 
>1.7.6
>
Comment 3 Joanmarie Diggs (IRC: joanie) 2011-07-24 20:13:18 UTC 
Created attachment 192577 [details] [review]
proposed patch - includes ATK version bump

Bumped the ATK version, "just in case" -- although it will only get checked if tests are enabled.
Comment 4 Mike Gorse 2011-07-24 20:45:08 UTC 
Comment on attachment 192577 [details] [review]
proposed patch - includes ATK version bump






>From ca06e0065849054b0d3223ee0600787f8b2c3ab4 Mon Sep 17 00:00:00 2001
>From: Joanmarie Diggs <joanmarie.diggs@gmail.com>
>Date: Sat, 2 Jul 2011 17:15:18 -0400
>Subject: [PATCH] Fix for bug 653874 - New ATK Roles
>
>---
> configure.ac    |    2 +-
> pyatspi/role.py |   43 +++++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 42 insertions(+), 3 deletions(-)
>
>diff --git a/configure.ac b/configure.ac
>index 9c08c55..8578dd9 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -57,7 +57,7 @@ if test "$enable_tests" = "yes"; then
>         AC_SUBST(LIB_XML_LIBS)
>         AC_SUBST(LIB_XML_CFLAGS)
> 
>-        PKG_CHECK_MODULES(ATK, [atk >= 1.17.0])
>+        PKG_CHECK_MODULES(ATK, [atk >= 2.1.0])
>         AC_SUBST(ATK_LIBS)
>         AC_SUBST(ATK_CFLAGS)
> 
>diff --git a/pyatspi/role.py b/pyatspi/role.py
>index 5973b87..fb44a5d 100644
>--- a/pyatspi/role.py
>+++ b/pyatspi/role.py
>@@ -108,7 +108,20 @@ class Role(_Enum):
>                 87:'ROLE_FORM',
>                 88:'ROLE_LINK',
>                 89:'ROLE_INPUT_METHOD_WINDOW',
>-                90:'ROLE_LAST_DEFINED',
>+                90:'ROLE_TABLE_ROW',
>+                91:'ROLE_TREE_ITEM',
>+                92:'ROLE_DOCUMENT_SPREADSHEET',
>+                93:'ROLE_DOCUMENT_PRESENTATION',
>+                94:'ROLE_DOCUMENT_TEXT',
>+                95:'ROLE_DOCUMENT_WEB',
>+                96:'ROLE_DOCUMENT_EMAIL',
>+                97:'ROLE_COMMENT',
>+                98:'ROLE_LIST_BOX',
>+                99:'ROLE_GROUPING',
>+                100:'ROLE_IMAGE_MAP',
>+                101:'ROLE_NOTIFICATION',
>+                102:'ROLE_INFO_BAR',
>+                103:'ROLE_LAST_DEFINED',
>         }
> 
> ROLE_ACCELERATOR_LABEL = Role(1)
>@@ -126,13 +139,19 @@ ROLE_CHECK_MENU_ITEM = Role(8)
> ROLE_COLOR_CHOOSER = Role(9)
> ROLE_COLUMN_HEADER = Role(10)
> ROLE_COMBO_BOX = Role(11)
>+ROLE_COMMENT = Role(97)
> ROLE_DATE_EDITOR = Role(12)
> ROLE_DESKTOP_FRAME = Role(14)
> ROLE_DESKTOP_ICON = Role(13)
> ROLE_DIAL = Role(15)
> ROLE_DIALOG = Role(16)
> ROLE_DIRECTORY_PANE = Role(17)
>+ROLE_DOCUMENT_EMAIL = Role(96)
> ROLE_DOCUMENT_FRAME = Role(82)
>+ROLE_DOCUMENT_PRESENTATION = Role(93)
>+ROLE_DOCUMENT_SPREADSHEET = Role(92)
>+ROLE_DOCUMENT_TEXT = Role(94)
>+ROLE_DOCUMENT_WEB = Role(95)
> ROLE_DRAWING_AREA = Role(18)
> ROLE_EDITBAR = Role(77)
> ROLE_EMBEDDED = Role(78)
>@@ -146,23 +165,28 @@ ROLE_FOOTER = Role(72)
> ROLE_FORM = Role(87)
> ROLE_FRAME = Role(23)
> ROLE_GLASS_PANE = Role(24)
>+ROLE_GROUPING = Role(99)
> ROLE_HEADER = Role(71)
> ROLE_HEADING = Role(83)
> ROLE_HTML_CONTAINER = Role(25)
> ROLE_ICON = Role(26)
> ROLE_IMAGE = Role(27)
>+ROLE_IMAGE_MAP = Role(100)
>+ROLE_INFO_BAR = Role(102)
> ROLE_INPUT_METHOD_WINDOW = Role(89)
> ROLE_INTERNAL_FRAME = Role(28)
> ROLE_INVALID = Role(0)
> ROLE_LABEL = Role(29)
>-ROLE_LAST_DEFINED = Role(90)
>+ROLE_LAST_DEFINED = Role(103)
> ROLE_LAYERED_PANE = Role(30)
> ROLE_LINK = Role(88)
> ROLE_LIST = Role(31)
>+ROLE_LIST_BOX = Role(98)
> ROLE_LIST_ITEM = Role(32)
> ROLE_MENU = Role(33)
> ROLE_MENU_BAR = Role(34)
> ROLE_MENU_ITEM = Role(35)
>+ROLE_NOTIFICATION = Role(101)
> ROLE_OPTION_PANE = Role(36)
> ROLE_PAGE = Role(84)
> ROLE_PAGE_TAB = Role(37)
>@@ -190,6 +214,7 @@ ROLE_STATUS_BAR = Role(54)
> ROLE_TABLE = Role(55)
> ROLE_TABLE_CELL = Role(56)
> ROLE_TABLE_COLUMN_HEADER = Role(57)
>+ROLE_TABLE_ROW = Role(90)
> ROLE_TABLE_ROW_HEADER = Role(58)
> ROLE_TEAROFF_MENU_ITEM = Role(59)
> ROLE_TERMINAL = Role(60)
>@@ -198,6 +223,7 @@ ROLE_TOGGLE_BUTTON = Role(62)
> ROLE_TOOL_BAR = Role(63)
> ROLE_TOOL_TIP = Role(64)
> ROLE_TREE = Role(65)
>+ROLE_TREE_ITEM = Role(91)
> ROLE_TREE_TABLE = Role(66)
> ROLE_UNKNOWN = Role(67)
> ROLE_VIEWPORT = Role(68)
>@@ -292,6 +318,19 @@ ROLE_NAMES = {
>         ROLE_FORM:'form',
>         ROLE_LINK:'link',
>         ROLE_INPUT_METHOD_WINDOW:'input method window',
>+        ROLE_TABLE_ROW:'table row',
>+        ROLE_TREE_ITEM:'tree item',
>+        ROLE_DOCUMENT_SPREADSHEET:'document spreadsheet',
>+        ROLE_DOCUMENT_PRESENTATION:'document presentation',
>+        ROLE_DOCUMENT_TEXT:'document text',
>+        ROLE_DOCUMENT_WEB:'document web',
>+        ROLE_DOCUMENT_EMAIL:'document email',
>+        ROLE_COMMENT:'comment',
>+        ROLE_LIST_BOX:'list box',
>+        ROLE_GROUPING:'grouping',
>+        ROLE_IMAGE_MAP:'image map',
>+        ROLE_NOTIFICATION:'notification',
>+        ROLE_INFO_BAR:'info bar',
> }
> 
> #END----------------------------------------------------------------------------
>-- 
>1.7.6
>
Comment 5 Joanmarie Diggs (IRC: joanie) 2011-07-24 21:10:03 UTC 
Comment on attachment 192577 [details] [review]
proposed patch - includes ATK version bump

http://git.gnome.org/browse/pyatspi2/commit/?id=626169f39498351b64600de1936a394b38b5b754
Comment 6 André Klapper 2015-02-27 16:41:18 UTC 
[Moving at-spi/pyatspi2 bugs to separate product. See bug 740075]