After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651343 - New ATK Roles
New ATK Roles
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
ATK maintainer(s)
Depends on:
Blocks: 638537 639479 651358 653872 653874
 
 
Reported: 2011-05-28 19:46 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-01-31 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (5.04 KB, patch)
2011-07-02 22:00 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review
Patch to add ATK_ROLE_LEVEL_BAR (1.48 KB, patch)
2012-12-13 23:35 UTC, Mike Gorse
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2011-05-28 19:46:56 UTC
The following roles were agreed upon as being desirable additions to ATK:

* ATK_ROLE_TABLE_ROW
* ATK_ROLE_TREE_ITEM
* ATK_ROLE_DOCUMENT_SPREADSHEET
* ATK_ROLE_DOCUMENT_PRESENTATION
* ATK_ROLE_DOCUMENT_TEXT
* ATK_ROLE_DOCUMENT_WEB
* ATK_ROLE_DOCUMENT_EMAIL
* ATK_ROLE_LIST_BOX
* ATK_ROLE_GROUPING (a group of widgets, can have a title)
* ATK_ROLE_IMAGE_MAP
* ATK_ROLE_NOTIFICATION
* ATK_ROLE_COMMENT (e.g. OOo/LibreOffice Writer or Calc: Insert->Comment)
Comment 1 André Klapper 2011-06-23 22:07:02 UTC
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 .
PLEASE NOTE:
If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla.
Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Comment 2 Joanmarie Diggs (IRC: joanie) 2011-06-30 21:14:39 UTC
I'm thinking we might also want ATK_ROLE_INFO_BAR. Uses:
* Browsers that display those 'do you want to save this password?' bar
* http://developer.gnome.org/gtk/stable/GtkInfoBar.html
Comment 3 Joanmarie Diggs (IRC: joanie) 2011-07-02 22:00:58 UTC
Created attachment 191168 [details] [review]
proposed patch

Tested along with the patches I am about to attach to bug 653872 and bug 653874, and this change to Gtk+ 3:

~~~~~~
diff --git a/gtk/gtkinfobar.c b/gtk/gtkinfobar.c
index 87f6d3b..cb0e02d 100644
--- a/gtk/gtkinfobar.c
+++ b/gtk/gtkinfobar.c
@@ -1106,7 +1106,7 @@ gtk_info_bar_set_message_type (GtkInfoBar     *info_bar,
           GtkStockItem item;
           const char *stock_id = NULL;
 
-          atk_object_set_role (atk_obj, ATK_ROLE_ALERT);
+          atk_object_set_role (atk_obj, ATK_ROLE_INFO_BAR);
 
           switch (message_type)
             {
~~~~~~

Accerciser now reports that GtkInfoBar instances from gtk3-demo as having role 'info bar'.

Please review. Thanks!
Comment 4 Joanmarie Diggs (IRC: joanie) 2011-07-07 17:42:13 UTC
Comment on attachment 191168 [details] [review]
proposed patch

Committed to the master branch:

http://git.gnome.org/browse/atk/commit/?id=4f88969d708b83293d656afb79375538bc95973f
Comment 5 Mike Gorse 2012-12-03 17:11:27 UTC
Gtk now has a "level bar" widget intended to be used as a level indicator (for instance, to display the strength of a password or the charge level of a battery). Should we add an atk role for this? I'm not sure whether, ie, it makes sense to use ATK_ROLE_INFO_BAR or not.
Comment 6 Mike Gorse 2012-12-13 23:35:09 UTC
Created attachment 231528 [details] [review]
Patch to add ATK_ROLE_LEVEL_BAR
Comment 7 Mike Gorse 2012-12-13 23:36:00 UTC
Re-opening because I think that we want the new role, and it seems easier than filing a new bug.
Comment 8 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-01-31 15:17:25 UTC
Review of attachment 231528 [details] [review]:

After a chat on the weekly a11y meeting, we concluded that having that role would be good. Looks good to me.
Comment 9 Mike Gorse 2013-01-31 16:42:43 UTC
Comment on attachment 231528 [details] [review]
Patch to add ATK_ROLE_LEVEL_BAR

Committed as e5d2a9.