GNOME Bugzilla – Bug 596242
Support X-GNOME-FullName
Last modified: 2010-01-26 21:50:11 UTC
Banshee should support X-GNOME-FullName in it's .desktop files: Name=Banshee Media Player => Name=Banshee GenericName=Media Player and a new key: X-GNOME-FullName=Banshee Media Player
For reference, the GNOME Goal page is http://live.gnome.org/GnomeGoals/CorrectDesktopFiles We probably want to wait until after the 1.6 release to do this, to avoid breaking translations of the desktop files.
I don't think this would break anything really - I don't think "Banshee" would need to be marked for translation (at least ru and zh_CN don't translate it atm), and we already have "Media Player" marked for translation.
If I understand correctly the comment in bug 596240, with this change, the menu entry would become "Banshee" for those running GNOME < 2.28. Are we OK with this, or should we handle it differently depending on the GNOME version ?
In the openSUSE spec file we do this: %suse_update_desktop_file -r -N "Banshee" -G "Media Player" %{name} Which updates the Name to "Banshee" and the GenericName to "Media Player". We've done this for quite some time since the default menu interface in openSUSE GNOME is the Slab/App Browser. This means the tile looks like this: .------------------------------. | /| | | |__ | | /|_ \ Banshee | | | |_| | Media Player | | \___/ | `------------------------------` In upstream GNOME we keep Name as "Banshee Media Player" since the traditional GNOME Main Menu does not show GenericName at all, so it looks like this: .---------------------------. | b | Banshee Media Player | `---------------------------` From what I understand, if this change is made, in GNOME < 2.28, users would see: .---------------------------. | b | Banshee | `---------------------------` Displaying just the name "Banshee" doesn't tell the user anything about what the application does. The adjusted .desktop file we use in openSUSE is much more technically correct, and I would love to see GNOME upstream make use of this, but I also do not want to break any usability right now. So maybe we wait a few more GNOME cycles? Also, I hope you enjoyed my poor attempt at ASCII art.
Yeah, looks like Stephane is doing this conditionally in F-Spot based on whether gnome < 2.28
(In reply to comment #4) > So maybe we wait a few more GNOME cycles? Well I think GNOME 2.28 works just fine with the "old" .desktop files which means the change is only really *needed* for gnome-shell... Question: is any distribution beside openSUSE actually going to ship the next (unreleased) banshee and GNOME < 2.28?
That's an irrelevant question since Banshee will be supported on and released for (albeit not officially) distros shipping GNOME < 2.28. We can do it conditionally though, but this might break translations as Bertrand mentioned in comment #3. From what I understand, the traditional main menu (and friends) are being patched in 2.28 to read X-GNOME-FullName instead of Name, and gnome-shell will use Name/GenericName as it should. This solves the problem we have had in openSUSE for years.
I just pushed a patch for this. I guess it's not perfect since it will only put out which ever name is used for translation, but in practice that doesn't matter since both strings are already translated b/c of uses elsewhere. One thing to note: "Play and organize your media collection" was not getting pulled out for translation in master - that sucks - probably happened with the .desktop file/common.desktop rework from several months ago So that's the only new string added to the .pot file with this patch.