After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590247 - Migrate from libglade to GtkBuilder
Migrate from libglade to GtkBuilder
Status: RESOLVED FIXED
Product: seahorse-plugins
Classification: Applications
Component: General
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: seahorse-plugins-maint
seahorse-plugins-maint
Depends on:
Blocks: 572883
 
 
Reported: 2009-07-30 10:54 UTC by André Klapper
Modified: 2009-11-26 22:46 UTC
See Also:
GNOME target: 2.30.x
GNOME version: ---


Attachments
Migrates to GtkBuilder (171.27 KB, patch)
2009-08-20 00:23 UTC, Adam Schreiber
none Details | Review
Fixes build (1.02 KB, patch)
2009-08-23 14:03 UTC, Adam Schreiber
none Details | Review
Modifies POTFILES.po (1.76 KB, patch)
2009-08-23 14:04 UTC, Adam Schreiber
none Details | Review
Get rid of libglade (5.06 KB, patch)
2009-08-24 15:37 UTC, Pablo Castellano (IRC: pablog)
none Details | Review
proposed patch (1.43 KB, patch)
2009-11-03 02:59 UTC, Pablo Castellano (IRC: pablog)
none Details | Review

Description André Klapper 2009-07-30 10:54:20 UTC
See http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder .
And bug 577875 that was already fixed for Seahorse.
Comment 1 Adam Schreiber 2009-08-20 00:23:15 UTC
Created attachment 141200 [details] [review]
Migrates to GtkBuilder

Will commit for 2.29.
Comment 2 Pablo Castellano (IRC: pablog) 2009-08-22 16:04:09 UTC
Seahorse-plugins won't compile with you patch. Some changes in Makefile.am are still needed. I'll try to do it.
Comment 3 Adam Schreiber 2009-08-23 14:03:21 UTC
Created attachment 141497 [details] [review]
Fixes build
Comment 4 Adam Schreiber 2009-08-23 14:04:02 UTC
Created attachment 141498 [details] [review]
Modifies POTFILES.po
Comment 5 Pablo Castellano (IRC: pablog) 2009-08-24 15:35:24 UTC
The gedit plugin seems to work correctly.

The applet plugin instead, when you click on Preferences, and then on the Close button, it doesn't close (it seems like the signal is not connected).

I have not tested epiphany and nautilus neither.


Here is a patch to fix the installation: 0001-Get-rid-of-libglade.patch
Comment 6 Pablo Castellano (IRC: pablog) 2009-08-24 15:37:15 UTC
Created attachment 141568 [details] [review]
Get rid of libglade

Here is a patch to fix the built (you already fixed it) installation: 
0001-Get-rid-of-libglade.patch
Comment 7 Pablo Castellano (IRC: pablog) 2009-08-24 15:40:33 UTC
The gedit plugin seems to work correctly.

In the applet plugin instead, when you click on Preferences, and then on the Close button, the window doesn't close (it seems like the signal is not connected) and it didn't happen before with libglade.

I have not tested nautilus deeply but seems to work.

I have not tested epiphany (I don't know what it does).
Comment 8 Javier Jardón (IRC: jjardon) 2009-10-11 14:02:27 UTC
Any update in the status of this bug?

This is one of the lastest Gnome modules depending on libglade ;)
http://www.gnome.org/~fpeters/299.html
Comment 9 Adam Schreiber 2009-10-11 21:27:25 UTC
We can't touch this until after we branch because of the UI Freeze.
Comment 10 Pablo Castellano (IRC: pablog) 2009-11-03 02:59:27 UTC
Created attachment 146791 [details] [review]
proposed patch

There it was, the name of two signal callbacks changed and the gtkbuilder files weren't updated. This patch fixes it.

Anyways, it's still not working. Debugging the applet says:
<<<<<<<<<<<<<<<<<<<<
(seahorse-applet:13675): Gtk-WARNING **: Could not find signal handler 'on_widget_delete_event'

(seahorse-applet:13675): Gtk-WARNING **: Could not find signal handler 'on_widget_closed'
>>>>>>>>>>>>>>>>>>>>

I have spent more than 2 hours and I can't still understand why it cannot find the signal handlers.
Comment 11 Adam Schreiber 2009-11-03 03:01:20 UTC
I'll try to take a look at it tomorrow night.
Comment 12 Pablo Castellano (IRC: pablog) 2009-11-03 03:02:55 UTC
BTW, is seahorse-plugins/libseahorse/ a copy of libseahorse from seahorse, or
is it just completely independent? In the first case we would need to update
it..
Comment 13 Adam Schreiber 2009-11-03 03:07:00 UTC
It began as a copy of libseahorse from seahorse when we split the modules.  We try to apply fixes to one to the other, but there's probably some divergence.
Comment 14 André Klapper 2009-11-25 18:24:57 UTC
(In reply to comment #11)
> I'll try to take a look at it tomorrow night.

Hmm, any news? :)
Comment 15 Adam Schreiber 2009-11-26 22:46:31 UTC
All committed now and fixed the Preferences closing error messages.  See the last commit f2fd3fa3e4f9f0c834f38e098f0ccde2fed36ee9 for what I did to fix it.

While we're making plans, life gets in the way.