Created attachment 141200 [details] [review]
Migrates to GtkBuilder

Will commit for 2.29.

Seahorse-plugins won't compile with you patch. Some changes in Makefile.am are still needed. I'll try to do it.

Created attachment 141497 [details] [review]
Fixes build

Created attachment 141498 [details] [review]
Modifies POTFILES.po

The gedit plugin seems to work correctly.

The applet plugin instead, when you click on Preferences, and then on the Close button, it doesn't close (it seems like the signal is not connected).

I have not tested epiphany and nautilus neither.


Here is a patch to fix the installation: 0001-Get-rid-of-libglade.patch

Created attachment 141568 [details] [review]
Get rid of libglade

Here is a patch to fix the built (you already fixed it) installation: 
0001-Get-rid-of-libglade.patch

The gedit plugin seems to work correctly.

In the applet plugin instead, when you click on Preferences, and then on the Close button, the window doesn't close (it seems like the signal is not connected) and it didn't happen before with libglade.

I have not tested nautilus deeply but seems to work.

I have not tested epiphany (I don't know what it does).

Any update in the status of this bug?

This is one of the lastest Gnome modules depending on libglade ;)
http://www.gnome.org/~fpeters/299.html

We can't touch this until after we branch because of the UI Freeze.

Created attachment 146791 [details] [review]
proposed patch

There it was, the name of two signal callbacks changed and the gtkbuilder files weren't updated. This patch fixes it.

Anyways, it's still not working. Debugging the applet says:
<<<<<<<<<<<<<<<<<<<<
(seahorse-applet:13675): Gtk-WARNING **: Could not find signal handler 'on_widget_delete_event'

(seahorse-applet:13675): Gtk-WARNING **: Could not find signal handler 'on_widget_closed'
>>>>>>>>>>>>>>>>>>>>

I have spent more than 2 hours and I can't still understand why it cannot find the signal handlers.

I'll try to take a look at it tomorrow night.

BTW, is seahorse-plugins/libseahorse/ a copy of libseahorse from seahorse, or
is it just completely independent? In the first case we would need to update
it..

It began as a copy of libseahorse from seahorse when we split the modules.  We try to apply fixes to one to the other, but there's probably some divergence.

(In reply to comment #11)
> I'll try to take a look at it tomorrow night.

Hmm, any news? :)

All committed now and fixed the Preferences closing error messages.  See the last commit f2fd3fa3e4f9f0c834f38e098f0ccde2fed36ee9 for what I did to fix it.

While we're making plans, life gets in the way.