After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 577875 - Initial gtkbuilder port
Initial gtkbuilder port
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other All
: Normal enhancement
: 2.26.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks: 572883
 
 
Reported: 2009-04-03 18:36 UTC by Andreas Brauchli
Modified: 2009-07-12 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
port seahorse from libglade to gtkbuilder (328.84 KB, patch)
2009-04-03 19:06 UTC, Andreas Brauchli
none Details | Review
2nd part.. don't apply without part1 (880.12 KB, patch)
2009-04-03 19:07 UTC, Andreas Brauchli
none Details | Review
reworked port, also rebased on git master (501.59 KB, patch)
2009-04-05 19:47 UTC, Andreas Brauchli
needs-work Details | Review
second part.. don't apply without gktbuilder_port1.diff (721.96 KB, patch)
2009-04-05 19:49 UTC, Andreas Brauchli
needs-work Details | Review

Description Andreas Brauchli 2009-04-03 18:36:16 UTC
A patch follows that initially converts seahorse to use the new gtkbuilder format instead of libglade.
Comment 1 Andreas Brauchli 2009-04-03 19:06:36 UTC
Created attachment 132024 [details] [review]
port seahorse from libglade to gtkbuilder

Makes use of exporting functions via gmodule-2.0 and letting gtkbuilder handle the binding.
Note that some buttons are not bound yet.
first patch (don't apply without the second)
Comment 2 Andreas Brauchli 2009-04-03 19:07:29 UTC
Created attachment 132027 [details] [review]
2nd part.. don't apply without part1
Comment 3 Andreas Brauchli 2009-04-05 19:47:31 UTC
Created attachment 132145 [details] [review]
reworked port, also rebased on git master

includes bugfixes and missing signals
Comment 4 Andreas Brauchli 2009-04-05 19:49:10 UTC
Created attachment 132146 [details] [review]
second part.. don't apply without gktbuilder_port1.diff

no attachments >1Mb allowed..
Comment 5 Adam Schreiber 2009-05-03 21:01:33 UTC
Key generation is broken.
Comment 6 Stef Walter 2009-07-11 14:54:23 UTC
Thanks for doing all that work Andreas. I've committed this change. I've changed the handler prefix to 'on_'. Also made hundreds of changes and fixes to the code. 
Comment 7 Claude Paroz 2009-07-11 20:45:05 UTC
Please don't forget to update POTFILES.in whenever there are file renaming or moving. I cared for it in this case.
Now I saw some inconsistency in GTK version required for seahorse. configure.in require gtk > 2.10, but GTKBuilder files require gtk 2.16. This is important for me because if it is really 2.16, I can propose a patch to remove markup from translatable strings in GTKBuilder files. However this is only supported from GTK+ 2.16 on.
Comment 8 Andreas Brauchli 2009-07-12 09:43:15 UTC
thank you stef for your additional hours of work!

as for gtk 2.16, my _personal_ opinion is that we should switch upstream to gtk 2.16 since this is the general direction of gnome apps with gtkbuilder, however not all major distros are upgraded yet.. although i don't think that people running stable distro versions are likely to upgrade to seahorse-trunk (except maybe gentoo people)

here's a quick rundown of which major distros feature a gtk version >= 2.16 in their latest stable release:

ubuntu since jaunty (april 2009), the latest long term supported version of april 2008 (hardy), which is supported through april 2011 is still on gtk 2.12.9

suse 11.1 is still on 2.14.4 (suse 11.2 is scheduled for november 2009 with gnome 2.28)

fedora since leonidas v11 (june 2009)

debian lenny is on 2.12 (june 2009), squeeze (testing) is good

mandriva since 2009.1 (april 2009)

PC Linux OS 2009.2 is still on 2.14

slackware-current still on 2.14

gentoo stable and unstable on 2.14

freebsd since 7.2 (may 2009)

source: distrowatch.com
Comment 9 Adam Schreiber 2009-07-12 13:12:33 UTC
I wouldn't worry about Slackware as they don't ship GNOME.