After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588746 - [audiotestsrc] Make sure tags are properly serialized in the dataflow
[audiotestsrc] Make sure tags are properly serialized in the dataflow
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 588745
Blocks:
 
 
Reported: 2009-07-16 07:13 UTC by Edward Hervey
Modified: 2009-07-20 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
audiotestsrc: Make sure tags are properly serialized. (1.19 KB, patch)
2009-07-16 07:14 UTC, Edward Hervey
committed Details | Review
possible new patch (1.10 KB, patch)
2009-07-20 10:59 UTC, Wim Taymans
none Details | Review

Description Edward Hervey 2009-07-16 07:13:55 UTC
Adder pushes out some tags from the _create() virtual method. The problem is that it has no knowledge of the overall dataflow (i.e. when newsegment has been pushed downstream).

The following patch makes audiotestsrc relay it to the base class for proper emission.
Comment 1 Edward Hervey 2009-07-16 07:14:27 UTC
Created attachment 138508 [details] [review]
audiotestsrc: Make sure tags are properly serialized.

We do this by letting the basesrc base class handle the tags.
Comment 2 Edward Hervey 2009-07-18 07:29:57 UTC
Any chance to get this one in ? It's causing havoc for pitivi :(
Comment 3 Jan Schmidt 2009-07-19 20:20:54 UTC
Yes please
Comment 4 Edward Hervey 2009-07-20 06:51:05 UTC
commit 196b38d4ef73d937de02f3a020c16afbd81f13c8
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Sun Jul 12 10:07:34 2009 +0200

    audiotestsrc: Make sure tags are properly serialized. Fixes #588746
    
    We do this by letting the basesrc base class handle the tags.

Comment 5 Wim Taymans 2009-07-20 10:59:32 UTC
Created attachment 138795 [details] [review]
possible new patch

unfortunately gst_element_send_event() takes the state lock and can't thus be called from a streaming thread. Instead this patch calls the send_event vmethod directly as a quick fix until there is a nice API in basesrc for this.
Comment 6 Wim Taymans 2009-07-20 11:17:35 UTC
Added patch and NULL check.

commit 0bb9b75a7535b435779a5776fd2ab5e8bf1e9869
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Jul 20 12:51:30 2009 +0200

    audiotestsrc: call send_event directly
    
    We can't call gst_element_send_event() from a streaming thread as it gets the
    state lock. Instead call the send_event method directly until we have a nice API
    for this in basesrc.
    
    Fixes #588746