After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 588745 - [basesrc] Serialize tags in the dataflow
[basesrc] Serialize tags in the dataflow
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 588746
 
 
Reported: 2009-07-16 07:08 UTC by Edward Hervey
Modified: 2009-07-20 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
basesrc: Serialize tags into the dataflow. (2.16 KB, patch)
2009-07-16 07:08 UTC, Edward Hervey 		committed Details | Review
make the tag queuing threadsafe (1.93 KB, patch)
2009-07-20 11:31 UTC, Wim Taymans 		committed Details | Review

Description Edward Hervey 2009-07-16 07:08:06 UTC 
Currently tags sent to a GstBaseSrc from an application are discarded (There's a FIXME about this).

This also prohibits some subclasses to properly push out tags properly serialized in the dataflow (only the base class knows when to push it out (i.e. after newsegment)).
Comment 1 Edward Hervey 2009-07-16 07:08:29 UTC 
Created attachment 138507 [details] [review]
basesrc: Serialize tags into the dataflow.
Comment 2 Edward Hervey 2009-07-18 07:29:24 UTC 
Any chance to get this one in ?
Comment 3 Jan Schmidt 2009-07-19 20:20:09 UTC 
Oh right, yes please do ASAP
Comment 4 Edward Hervey 2009-07-20 06:50:26 UTC 
commit 1d0c6a669fa6443e6e12a0375fd2c83218c29aca
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Sun Jul 12 10:04:01 2009 +0200

    basesrc: Serialize tags into the dataflow. Fixes #588745
Comment 5 Wim Taymans 2009-07-20 11:31:36 UTC 
Created attachment 138806 [details] [review]
make the tag queuing threadsafe

This patch makes the tag queuing threadsafe.