GNOME Bugzilla – Bug 559162
Improve performance logging annotations
Last modified: 2008-11-03 21:16:47 UTC
patch coming.
Created attachment 121896 [details] [review] The patch
+static void +start_fontconfig_monitor (GnomeXSettingsManager *manager) +{ + gnome_settings_profile_start (NULL); + + manager->priv->fontconfig_handle = fontconfig_monitor_start ((GFunc) fontconfig_callback, manager); + + gnome_settings_profile_end (NULL); +} + +static void +stop_fontconfig_monitor (GnomeXSettingsManager *manager) +{ + fontconfig_monitor_stop (manager->priv->fontconfig_handle); + manager->priv->fontconfig_handle = NULL; +} That looks like overkill to me. Also, indentation is messed up in lots of places.
(In reply to comment #2) > +static void > +start_fontconfig_monitor (GnomeXSettingsManager *manager) > +{ > + gnome_settings_profile_start (NULL); > + > + manager->priv->fontconfig_handle = fontconfig_monitor_start ((GFunc) > fontconfig_callback, manager); > + > + gnome_settings_profile_end (NULL); > +} > + > +static void > +stop_fontconfig_monitor (GnomeXSettingsManager *manager) > +{ > + fontconfig_monitor_stop (manager->priv->fontconfig_handle); > + manager->priv->fontconfig_handle = NULL; > +} > > That looks like overkill to me. The functions are static, so they are inlined anyway. It's cleaner this way, specially after the patch in bug 559166 adds more logic to these functions. > Also, indentation is messed up in lots of places. >
2008-11-03 Behdad Esfahbod <behdad@gnome.org> * gnome-settings-daemon/gnome-settings-manager.c (_load_file): * gnome-settings-daemon/gnome-settings-plugin-info.c (gnome_settings_plugin_info_fill_from_file), (load_plugin_module): * plugins/font/gsd-font-manager.c (child_watch_cb), (spawn_with_input): * plugins/keyboard/gsd-keyboard-xkb.c (gsd_keyboard_xkb_init): * plugins/xrandr/gsd-xrandr-manager.c (gsd_xrandr_manager_start): * plugins/xsettings/gsd-xsettings-manager.c (child_watch_cb), (spawn_with_input), (start_fontconfig_monitor), (stop_fontconfig_monitor), (gnome_xsettings_manager_start), (gnome_xsettings_manager_stop): Improve performance logging annotations (bug #559162)