After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559166 - [clipboard,mouse,fontconfig] Start manager in idle callback
[clipboard,mouse,fontconfig] Start manager in idle callback
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-03 19:08 UTC by Behdad Esfahbod
Modified: 2008-11-06 03:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch (7.17 KB, patch)
2008-11-03 19:11 UTC, Behdad Esfahbod 		committed Details | Review

Description Behdad Esfahbod 2008-11-03 19:08:07 UTC 
These do not need to run before any windows are mapped on the screen, so we can delay starting them, to do them in parallel with other services.

However, make sure fontconfig caches are up to date during initialization.
Comment 1 Behdad Esfahbod 2008-11-03 19:11:32 UTC 
Created attachment 121899 [details] [review]
the patch
Comment 2 Jens Granseuer 2008-11-03 21:02:54 UTC 
enum {
         GSD_CLIPBOARD_ERROR_RUNNING,
         GSD_CLIPBOARD_ERROR_FAILED
...

The enum should be unused now. Remove it as well.

Plus the usual identation issues.
Comment 3 Behdad Esfahbod 2008-11-03 21:34:28 UTC 
Committed after fixing both issues.

2008-11-03  Behdad Esfahbod  <behdad@gnome.org>

        * plugins/clipboard/gsd-clipboard-manager.c
        (start_clipboard_idle_cb), (gsd_clipboard_manager_start):
        Start manager in idle callback (bug #559166)

        * plugins/mouse/gsd-mouse-manager.c (gsd_mouse_manager_idle_cb),
        (gsd_mouse_manager_start):
        Start manager in idle callback (bug #559166)

        * plugins/xsettings/fontconfig-monitor.c (fontconfig_cache_update),
        (update):
        * plugins/xsettings/fontconfig-monitor.h:
        * plugins/xsettings/gsd-xsettings-manager.c
        (start_fontconfig_monitor_idle_cb), (start_fontconfig_monitor),
        (stop_fontconfig_monitor):
        Start fontconfig monitors in idle callback.  However, make sure
        fontconfig caches are up to date during initialization (bug #559166)
Comment 4 Behdad Esfahbod 2008-11-06 03:40:02 UTC 
Note that the fontconfig fix here is not optimal.  Filed bug 559550 to follow up.