After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548524 - Personal last.fm radio stations are not saved
Personal last.fm radio stations are not saved
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Last.fm
git master
Other All
: Normal normal
: 1.6
Assigned To: Gabriel Burt
Depends on:
Blocks:
 
 
Reported: 2008-08-19 20:17 UTC by Alex Launi
Modified: 2009-03-09 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alex Launi 2008-08-19 20:17:11 UTC
Please describe the problem:
User last.fm stations do not get saved between banshee sessions.

Steps to reproduce:
1. Right click the last.fm source, and add a user's station of type "Personal"
2. Close banshee
3. Open banshee, the personal station is gone. stations of other type remain


Actual results:
see above

Expected results:
the Personal station should be persistent upon reopening Banshee

Does this happen every time?
yes it does

Other information:
Stack trace from running banshee-1 --debug

[Warn  16:16:53.520] Not in main thread! -    at System.Environment.get_StackTrace()
   at Banshee.Base.ThreadAssist.AssertInMainThread() in /home/alauni/banshee/banshee/src/Core/Banshee.Services/Banshee.Base/ThreadAssist.cs:line 56
   at Banshee.Sources.SourceManager.AddSource(Banshee.Sources.Source source, Boolean isDefault) in /home/alauni/banshee/banshee/src/Core/Banshee.Services/Banshee.Sources/SourceManager.cs:line 139
   at Banshee.Sources.SourceManager.AddSource(Banshee.Sources.Source source) in /home/alauni/banshee/banshee/src/Core/Banshee.Services/Banshee.Sources/SourceManager.cs:line 134
   at Banshee.Sources.SourceManager.OnChildSourceAdded(Banshee.Sources.SourceEventArgs args) in /home/alauni/banshee/banshee/src/Core/Banshee.Services/Banshee.Sources/SourceManager.cs:line 260
   at System.MulticastDelegate.invoke_void_SourceEventArgs(Banshee.Sources.SourceEventArgs )
   at Banshee.Sources.Source.OnChildSourceAdded(Banshee.Sources.Source source) in /home/alauni/banshee/banshee/src/Core/Banshee.Services/Banshee.Sources/Source.cs:line 394
   at Banshee.Sources.Source.AddChildSource(Banshee.Sources.Source child) in /home/alauni/banshee/banshee/src/Core/Banshee.Services/Banshee.Sources/Source.cs:line 172
   at Banshee.Lastfm.Radio.StationEditor+<>c__CompilerGenerated31.<Run>c__32() in /home/alauni/banshee/banshee/src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Radio/StationEditor.cs:line 127
Comment 1 Richard Venneman 2008-08-26 13:13:20 UTC
I can confirm this bug
Comment 2 harrold.the.barrel 2008-09-01 20:21:04 UTC
Actually, this only happens with my personal last.fm account, the one I'm logged in with ... Banshee does remember personnal stations of other members ...
Comment 3 Alex Launi 2008-09-02 00:17:35 UTC
Actually I hadn't actually tried adding someone else's. That works for me, it's just adding my own that fails.
Comment 4 Chris Van Steenlandt 2008-10-07 18:57:13 UTC
I can confirm this bug too. I have this with my personal stations (I did not try yet with somebody elses). I'm running banshee 1.3.1 under Ubuntu 8.04 (installed via PPA 'unstable banshee').

Can we set the status of this bug to 'confirmed' ?
Comment 5 Andrew Conkling 2008-11-25 18:31:45 UTC
Banshee only shows personalized stations when "logged in": http://bugzilla.gnome.org/show_bug.cgi?id=512464#c13. (Personal radio, as far as I understand, isn't a subscriber station, so this shouldn't be the case.)
It doesn't log in automatically (bug 562229), so you have to click on the Last.fm pane to "log in", then your stations should load.
Is that the issue here as well? If not, can you please post the output of `banshee-1 --debug`? It should show something like this: http://bugzilla.gnome.org/show_bug.cgi?id=512464#c4 (i.e. that it's successfully logged in).

Also, if any of you are Last.fm subscribers, I'd be curious if you see the same behavior with your Loved Tracks station (which *is* a subscriber station).
Comment 6 fbugs 2008-11-26 12:51:35 UTC
I see the same problem, but the comment #5 by Andrew does not apply for me: Even after clicking on Last.fm my personal station does not appear. Debug output when clicking on Last.fm confirms that logging in works:

Last.fm State Changed to Connecting
Last.fm State Changed to Connected
Logged into Last.fm as yyy (not a subscriber)

As for the others only my own personal station gets lost. Using banshee 1.4.1 on debian lenny (banshee from debian experimental).
Comment 7 Matt 2008-11-26 19:01:24 UTC
I'm seeing the same results as comment #5. Clicking the main Last.fm pane does log me in, but the Personal station created before closing Banshee still did not re-appear.

Debug log:
[Debug 13:51:48.301] Last.fm State Changed to Connecting
[Debug 13:51:54.618] Last.fm State Changed to Connected
[Debug 13:51:54.627] Logged into Last.fm as user (not a subscriber)
Comment 8 fbugs 2009-01-11 11:08:42 UTC
So, more info:

I was a subscriber for a month and saw the behavior as described in comment #5. Furthermore a whole bunch of "personal stations" with my user name appeared, obviously they got saved somewhere when I repeatably created them before subscribing. Then I also saw the "Personal" station (after logging in).

So I guess the logic of "subscriber-no subscriber" is somewhere mixed up a bit, which is a problem for the "no subscriber" mostly. Also a non-subscriber should see his/her personal station.

thanks, florian (banshee 1.4.1)
Comment 9 Christoph Wurm 2009-01-28 17:20:25 UTC
I got the same bug when using the stable 1.4.2.
Once I built banshee from trunk, all the personal stations I had created reappeared.
If building from trunk does help, I think we can close this report as FIXED.
Comment 10 Gabriel Burt 2009-01-28 17:26:18 UTC
Yeah, this should be fixed in trunk.
Comment 11 Andrew Conkling 2009-03-09 14:42:56 UTC
(In reply to comment #10)
> Yeah, this should be fixed in trunk.

You changed the Target Milestone to 1.6 here; does this mean it will not be released in the 1.4 series? (Trying to answer a question about the versioning downstream.)
Comment 12 Gabriel Burt 2009-03-09 17:53:03 UTC
I don't think this fix was merged into the stable branch before 1.4.3 was released, so it will be fixed in the first 1.5.x release.