GNOME Bugzilla – Bug 512464
Last.fm doesn't show subscriber stations
Last modified: 2008-07-30 02:22:12 UTC
On the Last.fm radio plugin (which is simply great!) the following playlists are missing that I do not think a user can add by themselves: My radio, Loved - these are used once you have a paying user in Last.fm which most people are not, but still, for those that are it makes sense to have this option. Thanks
If you are a subscriber, you should see those options.
I am a subscriber but I still do not see these options. Maybe I am doing something wrong. I have also logged in again, but still it is the same. Thanks
I have been told by a different subscriber that this is working on trunk. Can you test and confirm?
I have just checked out trunk and compiled and also tested on 0.99.3. I am a subscriber. [Debug 19:22:43.619] Last.fm State Changed to Connecting [Debug 19:22:45.011] Last.fm State Changed to Connected [Debug 19:22:45.016] Logged into Last.fm as karlbowden (subscriber) I was not a subscriber when I first started using banshee (a week ago), but I am a subscriber now. The Loved and Personal (the channels listed as subscriber channels in the source) channels only show if I change the username to an invalid one. As soon as I change it back to my username, they disappear. The debug log is correctly identifying me as a subscriber, so I dunno.
It seems the function SetUserName in src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Radio/LastfmSource.cs is being called only after the connection state is disconnected or invalid. In SetUserName is the StationSource filter responsible for filtering out channels for non subscribers. I'm not sure what to change to fix this though or what consequence my lack of C# knowledge will cause.
Created attachment 112207 [details] [review] Always update last.fm channel list on last.fm state change
Can anyone test this in 1.0? (comment #6 on bug 526613) > As I just reported in bug 543206, I only get the ability to add a Loved station > after I load the Last.fm pane. Perhaps this is related to how the stations are > loaded too. Also, as I noted above, I have to load the pane first (which seems to log me in) before the station types are available in the Add Station dialog. Is that the same workaround behavior for you?
I can confirm that this bug was also in the released 1.0. The channel list was only being updated before logging in to last.fm, not after once it is member status is updated. The patch above for 1.0 made the channel list update after login to last.fm too. I have not had a chane to test this bug in current or if the patch will still apply to current.
Oh, and yes that is the work around I am using too. :-)
Thanks for checking. These three bugs all seem very closely related; maybe Gabriel can find the cause for all three. I'll see if I can find some time to test your patch to see exactly what it fixes. :)
Ok, I committed a patch that should fix this. Please svn up and test!
Now the stations show up, but only when I click on the Last.fm pane. Is this the intended behavior? (What's funny is that I have a dozen of them from when I had previously been adding them manually when I wanted to listen to them. :)
The stations are stored per last.fm username. Until you are logged in Banshee does not know if you are a subscriber or not. I think this is the responsible behavior for Banshee (IMO only). If you change the last.fm username in Banshee and create new channels for that username they will only be specific to when that username is connected to last.fm. Gabriel: Thanks I'll try and check today.
(In reply to comment #13) > The stations are stored per last.fm username. Until you are logged in Banshee > does not know if you are a subscriber or not. I think this is the responsible > behavior for Banshee (IMO only). Makes sense, but since my Last.fm username and password are saved, IMO Banshee should "remember" that and restore those stations when I start up. A minor bug, perhaps a separate one, but related.
*** Bug 543206 has been marked as a duplicate of this bug. ***
This appears to be working fine in svn trunk now. Will keep using trunk until 1.2 is released and keep an eye on it. Cheers guys.