After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513699 - Postscript backend embeds RGBA images totally wrong
Postscript backend embeds RGBA images totally wrong
Status: RESOLVED FIXED
Product: gnome-print
Classification: Deprecated
Component: Postscript backend
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 407578 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-01 14:08 UTC by Behdad Esfahbod
Modified: 2008-02-05 05:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch (2.67 KB, patch)
2008-02-01 14:09 UTC, Behdad Esfahbod
committed Details | Review

Description Behdad Esfahbod 2008-02-01 14:08:28 UTC
The 4-channel colorimage operator in Postscript assumes a CMYK colorspace.  That means, the RGBA images emitted will show up as black squares mostly...

Postscript doesn't support alpha channels.  Attaching patch that flattens images before emitting.
Comment 1 Behdad Esfahbod 2008-02-01 14:09:30 UTC
Created attachment 104204 [details] [review]
the patch

Tested and works.

I can commit.
Comment 2 Kjartan Maraas 2008-02-02 13:25:25 UTC
Please commit. Will this fix all the "my image was printed as a black square" bugreports?
Comment 3 Behdad Esfahbod 2008-02-05 05:07:04 UTC
Kjartan, did you commit this?

Yes it does.  At least all that have "4 colorimage" in the output.  Which I really believe is all.
Comment 4 Behdad Esfahbod 2008-02-05 05:17:18 UTC
2008-02-02  Kjartan Maraas  <kmaraas@gnome.org>

        * NEWS: Update.
        * libgnomeprint/gnome-print-ps2.c: (gnome_print_ps2_image):
        Patch from Behdad Esfahbod to fix graphics being printed as
        black squares. Closes bug #513699.

Comment 5 Behdad Esfahbod 2008-02-05 05:20:06 UTC
2008-02-05  Behdad Esfahbod  <behdad@gnome.org>

        * libgnomeprint/gnome-print-ps2.c (gnome_print_ps2_image): Fix
        rounding in RGBA flattening code.

Comment 6 Behdad Esfahbod 2008-02-05 05:23:18 UTC
*** Bug 407578 has been marked as a duplicate of this bug. ***