After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 505340 - Songs loaded from device before we have information about the device
Songs loaded from device before we have information about the device
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 443228 522543 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-24 02:19 UTC by Karol Krizka
Modified: 2008-03-15 02:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The simple patch (510 bytes, patch)
2007-12-24 02:22 UTC, Karol Krizka
committed Details | Review

Description Karol Krizka 2007-12-24 02:19:46 UTC
Hi guys,

This problem is present in the file plugins/generic-player/rb-generic-player-source.c

The function load_songs (line 709) uses folders that were determined by HAL and saved into the priv variable (line 725). However HAL loads the variable after load_songs is called (see line 223, get_device_info loads the priv variable), so load_songs never has the audio_folders.

This can cause rhythmbox to crash when the generic player contains music only in the folders determined by HAL and stored in audio_folders.

Calling get_device_info before load_songs fixes the problem. I attached the simple patch.
Comment 1 Karol Krizka 2007-12-24 02:22:40 UTC
Created attachment 101531 [details] [review]
The simple patch
Comment 2 Jonathan Matthew 2007-12-27 12:16:36 UTC
Committed to svn.  Thanks for figuring this one out.
Comment 3 Jonathan Matthew 2007-12-29 12:15:02 UTC
*** Bug 443228 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Matthew 2008-03-15 02:19:54 UTC
*** Bug 522543 has been marked as a duplicate of this bug. ***