GNOME Bugzilla – Bug 505340
Songs loaded from device before we have information about the device
Last modified: 2008-03-15 02:19:54 UTC
Hi guys, This problem is present in the file plugins/generic-player/rb-generic-player-source.c The function load_songs (line 709) uses folders that were determined by HAL and saved into the priv variable (line 725). However HAL loads the variable after load_songs is called (see line 223, get_device_info loads the priv variable), so load_songs never has the audio_folders. This can cause rhythmbox to crash when the generic player contains music only in the folders determined by HAL and stored in audio_folders. Calling get_device_info before load_songs fixes the problem. I attached the simple patch.
Created attachment 101531 [details] [review] The simple patch
Committed to svn. Thanks for figuring this one out.
*** Bug 443228 has been marked as a duplicate of this bug. ***
*** Bug 522543 has been marked as a duplicate of this bug. ***