GNOME Bugzilla – Bug 428328
evolution links/uses to popt
Last modified: 2012-02-13 14:12:37 UTC
Please describe the problem: evolution links to popt while such dependency should die in favor of GOption files using popt are : ./plugins/backup-restore/backup.c ./tools/evolution-launch-composer.c ./addressbook/tools/evolution-addressbook-import.c ./addressbook/tools/evolution-addressbook-export.c Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
see http://live.gnome.org/GnomeGoals/PoptGOption also see bug 335967
Matthew gave some GOption love to ./addressbook/tools/evolution-addressbook-export.c I'll work on others ASAP
./tools/evolution-launch-composer.c and ./addressbook/tools/evolution-addressbook-export.c are not even compiled and seem to be quite out of date. Maybe they should be deleted. Otherwise they don't only need to use GOption, they also need to be modified so that they can even compile again...
Created attachment 89661 [details] [review] Patch for plugins/backup_restore/backup.c Here is a patch for the only file of the three remaining that is being compiled.
Ghislain, thanks for this patch, I'll try it ASAP ./addressbook/tools/evolution-addressbook-export.c is still compiled see addressbook/tools $ vim Makefile.am evolution_addressbook_export_SOURCES = \ evolution-addressbook-export.c \ and I had a look at the import counterpart of it seems it would still work. If any dev could tell if it has any interest to resurect it to the build cycle of life ? :)
I think Ghislain MARY meant import, since export is already ported. Import is out of sync wrt apis. It still can be made work. Lets not worry about that for now. I would prefer to keep that as a dead file for now. Lets target dead files separately.
I have tested it and committed it along with the BASE_VERSION removal fix for this.
[sragavan@sragavan backup-restore]$ svn commit Sending backup-restore/ChangeLog Sending backup-restore/backup.c Transmitting file data .. Killed by signal 2. For some reason, Im not able to commit it. I tried waiting for 15 mins and gave up. Ill commit it when Im back at office on Friday.
for ./addressbook/tools/evolution-addressbook-export.c let's not commit in the wrong tree :)
Not sure which bug should depend on the other.. If some input is given on the desired direction here, I'm sure we can remove or polish the scripts/binaries a bit..
Committed the patch to head.
Gnome Goals wiki page [1] still says evo isn't patched yet and bug is still open... ping :) [1] http://live.gnome.org/GnomeGoals/PoptGOption
Thatz because, evolution-addressbook-import isn't still ported.
can we PLEASE port evolution-addressbook-import asap? it's only four modules still waiting for a complete port, and we definitely want to see the move to goption finished for GNOME 2.22. thanks in advance to any volunteers coming up with a patch.
I removed evolution-addressbook-import from trunk as part of bug #478704 [1] since, as far as I could tell, we have never shipped it in a release. So I think that completes this bug and completes our part of GNOME Goal #1. [1] http://bugzilla.gnome.org/show_bug.cgi?id=478704