After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335967 - Evolution should use the GOption API
Evolution should use the GOption API
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.6.x (obsolete)
Other All
: High normal
: ---
Assigned To: Philip Van Hoof
Evolution QA team
Depends on: 336085 428328
Blocks:
 
 
Reported: 2006-03-25 15:47 UTC by Philip Van Hoof
Modified: 2013-09-10 14:00 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Might not even compile. I'm still testing this one (3.72 KB, patch)
2006-03-25 15:48 UTC, Philip Van Hoof
needs-work Details | Review
Fixes some compilation problems (4.26 KB, patch)
2006-03-25 15:57 UTC, Philip Van Hoof
none Details | Review
Final version (4.72 KB, patch)
2006-03-25 16:35 UTC, Philip Van Hoof
accepted-commit_now Details | Review

Description Philip Van Hoof 2006-03-25 15:47:40 UTC
Please describe the problem:
Will attach a patch in a few seconds

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Philip Van Hoof 2006-03-25 15:48:29 UTC
Created attachment 61986 [details] [review]
Might not even compile. I'm still testing this one

This is just a tracking patch. It might not even compile. Working on it.
Comment 2 Philip Van Hoof 2006-03-25 15:57:48 UTC
Created attachment 61987 [details] [review]
Fixes some compilation problems

This new version fixes some compilation problems. Going to test the functionality in a few minutes.
Comment 3 Philip Van Hoof 2006-03-25 16:24:36 UTC
Other than a difference in output for "--help" this patch seems to work. Does the "--help" output difference matter? I'm not sure if it's possible to get the exact same output for "--help" using the GOption API.

Little silly test:

pvanhoof@lort:/opt/evo-test/bin$ ./evolution-2.6 --online --offline
./evolution-2.6: --online and --offline cannot be used together.
  Use ./evolution-2.6 --help for more information.
pvanhoof@lort:/opt/evo-test/bin$

--help?

pvanhoof@lort:/opt/evo-test/bin$ ./evolution-2.6 --help
Usage:
  evolution-2.6 [OPTION...] - Evolution

Help Options:
  -?, --help                     Show help options
  --help-all                     Show all help options
  --help-gtk                     Show GTK+ Options
  --help-bonobo-activation       Show Bonobo Activation options
  --help-gnome                   Show GNOME options
  --help-gnome-session           Show session management options
  --help-gnome-ui                Show GNOME GUI options

Application Options:
  -c, --component                Start Evolution activating the specified component
  --offline                      Start in offline mode
  --online                       Start in online mode
  --force-shutdown               Forcibly shut down all Evolution components
  --force-migrate                Forcibly re-migrate from Evolution 1.4
  --debug                        Send the debugging output of all components to a file.
  --disable-eplugin              Disable loading of any plugins.
  --display=DISPLAY              X display to use

pvanhoof@lort:/opt/evo-test/bin$ evolution --help
Usage: evolution [OPTION...]
  --load-modules=MODULE1,MODULE2,...     Dynamic modules to load

Help options
  -?, --help                             Show this help message
  --usage                                Display brief usage message

Application options
  -c, --component=STRING                 Start Evolution activating the
                                         specified component
  --offline                              Start in offline mode
  --online                               Start in online mode
  --force-shutdown                       Forcibly shut down all Evolution
                                         components
  --debug=STRING                         Send the debugging output of all
                                         components to a file.
  --disable-eplugin                      Disable loading of any plugins.

GTK+
  --gdk-debug=FLAGS                      Gdk debugging flags to set
  --gdk-no-debug=FLAGS                   Gdk debugging flags to unset
  --display=DISPLAY                      X display to use
  --screen=SCREEN                        X screen to use
  --sync                                 Make X calls synchronous
  --name=NAME                            Program name as used by the window
                                         manager
  --class=CLASS                          Program class as used by the window
                                         manager
  --gtk-debug=FLAGS                      Gtk+ debugging flags to set
  --gtk-no-debug=FLAGS                   Gtk+ debugging flags to unset
  --g-fatal-warnings                     Make all warnings fatal
  --gtk-module=MODULE                    Load an additional Gtk module

Bonobo activation Support
  --oaf-ior-fd=FD                        File descriptor to print IOR on
  --oaf-activate-iid=IID                 IID to activate
  --oaf-private                          Prevent registering of server with OAF

GNOME GConf Support

GNOME Library
  --disable-sound                        Disable sound server usage
  --enable-sound                         Enable sound server usage
  --espeaker=HOSTNAME:PORT               Host:port on which the sound server
                                         to use is running
  --version                              2.14.0

Session management
  --sm-client-id=ID                      Specify session management ID
  --sm-config-prefix=PREFIX              Specify prefix of saved configuration
  --sm-disable                           Disable connection to session manager

GNOME GUI Library
  --disable-crash-dialog                 Disable Crash Dialog
pvanhoof@lort:/opt/evo-test/bin$
Comment 4 Philip Van Hoof 2006-03-25 16:29:53 UTC
FYI

pvanhoof@lort:/opt/evo-test/bin$ ./evolution-2.6 --help-all
Usage:
  evolution-2.6 [OPTION...] - Evolution

Help Options:
  -?, --help                     Show help options
  --help-all                     Show all help options
  --help-gtk                     Show GTK+ Options
  --help-bonobo-activation       Show Bonobo Activation options
  --help-gnome                   Show GNOME options
  --help-gnome-session           Show session management options
  --help-gnome-ui                Show GNOME GUI options

GTK+ Options
  --class=CLASS                  Program class as used by the window manager
  --name=NAME                    Program name as used by the window manager
  --screen=SCREEN                X screen to use
  --sync                         Make X calls synchronous
  --gtk-module=MODULES           Load additional GTK+ modules
  --g-fatal-warnings             Make all warnings fatal

Bonobo Activation
  --oaf-ior-fd=FD                File descriptor to print IOR on
  --oaf-activate-iid=IID         IID to activate
  --oaf-private                  Prevent registering of server with OAF

GNOME Library
  --disable-sound                Disable sound server usage
  --enable-sound                 Enable sound server usage
  --espeaker=HOSTNAME:PORT       Host:port on which the sound server to use is r unning
  --version                      2.14.0

Session management
  --sm-client-id=ID              Specify session management ID
  --sm-config-prefix=PREFIX      Specify prefix of saved configuration
  --sm-disable                   Disable connection to session manager

GNOME GUI Library
  --disable-crash-dialog         Disable Crash Dialog

Application Options:
  -c, --component                Start Evolution activating the specified compon ent
  --offline                      Start in offline mode
  --online                       Start in online mode
  --force-shutdown               Forcibly shut down all Evolution components
  --force-migrate                Forcibly re-migrate from Evolution 1.4
  --debug                        Send the debugging output of all components to a file.
  --disable-eplugin              Disable loading of any plugins.
  --display=DISPLAY              X display to use

pvanhoof@lort:/opt/evo-test/bin$
Comment 5 Philip Van Hoof 2006-03-25 16:35:12 UTC
Created attachment 61990 [details] [review]
Final version

Added ChangeLog entry and fixed some very minor indentation problems. Please let me know if I may commit this one.
Comment 6 André Klapper 2006-03-25 16:38:44 UTC
for the records:
http://live.gnome.org/GnomeGoals/PoptGOption
Comment 7 André Klapper 2006-03-25 16:41:23 UTC
what the... gar... i'm running into firefox' reload bug again.
sorry for the noise.
Comment 8 Philip Van Hoof 2006-03-26 15:13:37 UTC
Adding a depends. Claudio raises an interesting question in that Bug #336085.

Comment 9 parthasarathi susarla 2006-03-26 16:55:09 UTC
The patch looks good. Adding harish in the CC list for the final approval. Thanks for patch philip
Comment 10 Philip Van Hoof 2006-03-26 20:38:32 UTC
Hey Partha and Harish. I'm going to keep this patch on hold as I need a little answer on this question:

According to the new documentation of the function, is "context = g_option_context_new (_("- Evolution"))" incorrect. It should be something like " - A emailer and groupware client". Please let me know what string I should use here.

Please take a look at Bug #336085 for more information.
Comment 11 parthasarathi susarla 2006-03-27 06:12:37 UTC
"A groupware client"  should suffice. what say??
Comment 12 André Klapper 2006-03-27 13:06:42 UTC
no. :-)

i already fixed this in 
/data/evolution.desktop.in.in (see bug 329744 on this), now it says:
        _GenericName=Groupware Suite
        _Comment=The Evolution PIM and Email Client

so either use desktop.in.in's generic name or the comment, whatever comes nearest to the goption doc (i don't know the doc and I'm too lazy to take a look myself).
Comment 13 Philip Van Hoof 2006-03-27 13:35:46 UTC
erm, is there a way to parse this out of that file? Not sure if that would be the best solution. Not doing so will of course add a translatable string. Perhaps is this something we want to avoid?
Comment 14 André Klapper 2006-03-27 17:07:55 UTC
erm, sorry, my comment was vague. my intention was not to say "parse desktop.in.in", but "go ahead and add a translatable string which is quite similar to the string in desktop.in.in".

i just want to avoid having one string stating "Groupware Suite" and one string stating "groupware client", that's why i commented on this.
Comment 15 Philip Van Hoof 2006-03-27 18:27:41 UTC
Ok. Waiting for the final approvement of Harish. ps. I'm going to use the Comment string of Andre's desktop.in.in file.
Comment 16 Philip Van Hoof 2006-03-31 08:34:52 UTC
Is there a conclusion for this patch? I'm still waiting for the final approvement of Harish.
Comment 17 Philip Van Hoof 2006-04-10 09:15:14 UTC
Changing status to NEEDINFO. I need confirmation from the maintainer of Evolution and about the string that should be used.
Comment 18 Philip Van Hoof 2006-04-10 09:16:11 UTC
Increasing priority field as the bug is solved but I need confirmation and info.
Comment 19 Harish Krishnaswamy 2006-04-19 10:54:11 UTC
sorry for the delay in getting to this. The patch looks OK to me. I prefer using the Comment string too - manages to convey much more than an abstract 'GroupWare Suite'. Approved for commit.
Comment 20 André Klapper 2007-04-11 15:35:28 UTC
not fixed, see bug 428328.
Comment 21 Philip Van Hoof 2007-04-11 18:43:56 UTC
Oh, I think you can simply remove the -lpopt from the configure.ac