After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419914 - [PATCH] Toggle elapsed time display style
[PATCH] Toggle elapsed time display style
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 128108 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-03-18 22:26 UTC by Steve Baker
Modified: 2012-03-28 22:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to toggle elapsed time display style (3.09 KB, patch)
2007-03-18 22:28 UTC, Steve Baker
none Details | Review
use a button instead (3.87 KB, patch)
2007-08-26 11:24 UTC, Jonathan Matthew
none Details | Review

Description Steve Baker 2007-03-18 22:26:53 UTC
The attached patch modifies rb-header.c to make it possible to change the elapsed time display from ascending to descending.

Clicking the elapsed time label will toggle the time_display gconf property so that users can easily switch between the display modes.

There is a tooltip set on the label to make it a bit more discoverable.

This patch is against the rhythmbox-0.9.8 tarball. I can re-diff against trunk if required.

XMMS is at least one player I know of which has similar behaviour. Also I think this is a good compromise between having the feature completely hidden and adding to a property dialog.
Comment 1 Steve Baker 2007-03-18 22:28:03 UTC
Created attachment 84857 [details] [review]
Patch to toggle elapsed time display style

This only modifies widgets/rb-header.c
Comment 2 Alex Lancaster 2007-03-19 06:43:36 UTC
Seems like a useful feature.  Haven't tested patch yet.
Comment 3 Jonathan Matthew 2007-08-23 10:59:55 UTC
We should probably combine this with bug 457333 if we're going to do anything with it.
Comment 4 Jonathan Matthew 2007-08-26 10:57:29 UTC
Er, I mean bug 457533.

Anyway, this is a reasonable approach, except that it's not particularly discoverable.  The only hint that you can change the time display mode is the tooltip.  The event box doesn't receive keyboard focus, so you can only get to it with the mouse.
Comment 5 Jonathan Matthew 2007-08-26 11:24:33 UTC
Created attachment 94354 [details] [review]
use a button instead

Using a button (with relief set to GTK_RELIEF_NONE) at least makes it keyboard-accessible and somewhat discoverable.  It takes up slightly more (vertical) space, though, which is a bit unfortunate.
Comment 6 Bastien Nocera 2007-11-07 13:48:41 UTC
*** Bug 128108 has been marked as a duplicate of this bug. ***
Comment 7 Bastien Nocera 2007-11-07 13:53:24 UTC
In bug #128108, I mentioned that it might be better to use something like:
time elapsed [=======       ] -time left
Comment 8 Jonathan Matthew 2012-03-28 22:09:38 UTC
The time display is now a button that toggles between elapsed and remaining time.