GNOME Bugzilla – Bug 399253
MS-Windows Theme Bottom Tab placement rendering glitches
Last modified: 2007-04-19 14:29:27 UTC
Please describe the problem: On GTK+ 2.10.8 on Windows with the MS-Windows them, when using tabs placed at the bottom of the notebook, there are glitches in the rendering (pieces from other parts of the screen are rendered over parts of the tab). This is particularly noticeable when using a single tab that spans the window width. The following appears in the console when the glitching happens: Gdk: gdk_drawable_copy_to_image: assertion `src_x >= 0' failed Gdk: gdk_drawable_copy_to_image: assertion `src_x >= 0' failed I'll post a screenshot. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 80857 [details] Screenshot showing glitches in bottom tab rendering
This seems to only happen when gtk_notebook_set_tab_label_packing() is set to have the tabs fill the allocated area.
Confirming this bug, occurs for me in GAIM beta 6 which comes packaged with GTK 2.7.10 rev a. Repost of my bug at gaim.sf.net https://sourceforge.net/tracker/?func=detail&atid=680472&aid=1665516&group_id=235 Summary: Beta6: Tab redraw error after mouse-over (flipped) Initial Comment: Message window tab re drawing error When I mouse over the X used to close a tab, and then move the mouse away again, the X is overlaid with an upside down version of the buddy icon. Better show a picture of this: http://img267.imageshack.us/img267/5641/beta6misdrawnug8.jpg
Confirmed also here, that's an annoying display glitch. To reproduce it with testgtk: - click on 'notebook' button - click on the 'rotate' button to put the tabs at the bottom - then move the main testgtk window (with all buttons) over the notebook tabs: you'll see these display glitches I do not get Gtk+ warnings though, with Gtk+ 2.10.11 Any hint on where to look for fixing this ? Thanks in advance, Arno
Created attachment 85664 [details] [review] Fix I believe this should fix it. Can you test this and let me know if there are any problems?
Created attachment 85665 [details] [review] Updated patch Fixed a leak from the previous patch. Should be good now.
Confirmed, the patch fixes things for me as well. Arno
Fixed in HEAD and in 2-10. Can someone close this bug?
There's still a memory leak in the case of e.g. Windows Classic style, fixed by the following patch: << --- msw_style.c.old +++ msw_style.c @@ -2541,6 +2548,9 @@ draw_extension (GtkStyle * style, HDC dc; gint32 aPosition; + if (real_gap_side == GTK_POS_BOTTOM) + g_object_unref (pixmap); + dc = get_window_dc(style, window, state_type, x, y, width, height, &rect); if (real_gap_side == GTK_POS_TOP) >> Could someone apply it ? Arno
The fix for comment #9, and an additional fix for the LEFT/RIGHT tabs is in Bug #403470.