GNOME Bugzilla – Bug 403470
MS-Windows Theme tab placement other than on top leaks a pixbuf
Last modified: 2007-06-10 18:24:08 UTC
Please describe the problem: The code introduced in 2.10.7 to more accurately render tabs that are not on top (Bug #351678) leaks the pixbuf that is used to rotate the rendered tab. I have a simple patch that fixes this (attached). Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 81736 [details] [review] Patch to plug leak This also removes 3 unused variables, I figured they were straightforward and obvious enough not to warrant a separate patch.
Dom, I don't have commit access. Could you please commit this?
2007-02-05 Dom Lachowicz <domlachowicz@gmail.com> * modules/engines/ms-windows/msw_style.c: Fix bug 404506, caused by prematurely releasing a DC. By Hiroyuki Yamamoto * modules/engines/ms-windows/msw_style.c: Fix bug 403470 - leaking pixbufs when drawing rotated tabs. By Daniel Atallah
It looks like this (and bug 404506) unfortunately didn't make it into the 2.10.10 release.
It's now fixed in gtk-2-10 branch.
Created attachment 86630 [details] [review] leak fix for non-xp theme rendering path The fix that is applied only fixes the leakage in the xp-theme rendering. This patch fixes leakage in the non-XP theme rendering path.
Thanks Daniel.
*** Bug 431468 has been marked as a duplicate of this bug. ***