After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 403470 - MS-Windows Theme tab placement other than on top leaks a pixbuf
MS-Windows Theme tab placement other than on top leaks a pixbuf
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.10.x
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
: 431468 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-02-02 05:47 UTC by Daniel Atallah
Modified: 2007-06-10 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to plug leak (1.21 KB, patch)
2007-02-02 05:56 UTC, Daniel Atallah
committed Details | Review
leak fix for non-xp theme rendering path (739 bytes, patch)
2007-04-19 14:23 UTC, Daniel Atallah
committed Details | Review

Description Daniel Atallah 2007-02-02 05:47:31 UTC
Please describe the problem:
The code introduced in 2.10.7 to more accurately render tabs that are not on top (Bug #351678) leaks the pixbuf that is used to rotate the rendered tab.

I have a simple patch that fixes this (attached).

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Daniel Atallah 2007-02-02 05:56:01 UTC
Created attachment 81736 [details] [review]
Patch to plug leak

This also removes 3 unused variables, I figured they were straightforward and obvious enough not to warrant a separate patch.
Comment 2 Daniel Atallah 2007-02-03 17:54:18 UTC
Dom, I don't have commit access.  Could you please commit this?
Comment 3 Dominic Lachowicz 2007-02-12 20:57:35 UTC
2007-02-05  Dom Lachowicz <domlachowicz@gmail.com>

        * modules/engines/ms-windows/msw_style.c: Fix bug 404506, caused
        by prematurely releasing a DC. By Hiroyuki Yamamoto
        * modules/engines/ms-windows/msw_style.c: Fix bug 403470 - leaking
        pixbufs when drawing rotated tabs. By Daniel Atallah
Comment 4 Daniel Atallah 2007-03-13 18:31:47 UTC
It looks like this (and bug 404506) unfortunately didn't make it into the 2.10.10 release.
Comment 5 Cody Russell 2007-04-02 04:31:50 UTC
It's now fixed in gtk-2-10 branch.
Comment 6 Daniel Atallah 2007-04-19 14:23:35 UTC
Created attachment 86630 [details] [review]
leak fix for non-xp theme rendering path

The fix that is applied only fixes the leakage in the xp-theme rendering.
This patch fixes leakage in the non-XP theme rendering path.
Comment 7 Dominic Lachowicz 2007-04-19 14:45:20 UTC
Thanks Daniel.
Comment 8 Tor Lillqvist 2007-04-19 21:01:55 UTC
*** Bug 431468 has been marked as a duplicate of this bug. ***