After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 397305 - Provide a Tango style application icon for Sound capplet
Provide a Tango style application icon for Sound capplet
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
2.19.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-16 16:44 UTC by Luca Ferretti
Modified: 2007-06-29 17:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
screenshot of the current capplet icon (28.75 KB, image/png)
2007-02-16 15:32 UTC, Andreas Nilsson
  Details
Tangoified gnome-sound-properties (14.87 KB, application/x-bzip)
2007-02-17 20:42 UTC, Josef Vybíral
  Details
I forgot to make 24x24 so here is the complete package (16.29 KB, application/x-bzip)
2007-02-17 20:54 UTC, Josef Vybíral
  Details
gnome-sound-properties in gray (24.86 KB, application/zip)
2007-02-19 14:13 UTC, Josef Vybíral
  Details
Patch to use "gnome-sound-properties" named icon in .desktop file and in source (1.02 KB, patch)
2007-02-22 13:54 UTC, Luca Ferretti
committed Details | Review

Description Luca Ferretti 2007-01-16 16:44:08 UTC
The current icon for Sound capplet in control center is using wrong style (old GNOME instead new Tango).

Maybe we should also change its name and use the same name of the executable or
something like "preferences-desktop-sound" (see Icon Naming Spec).
Comment 1 Luca Ferretti 2007-01-16 16:52:27 UTC
The Icon Naming Spec defines "preferences-desktop-multimedia". Is this the proper icon for this capplet?

Note there is also "Multimedia System Selector" capplet from gnome-media.
Comment 2 Rodney Dawes 2007-01-16 21:19:06 UTC
The "multimedia system selector" capplet and the "Sound" capplet should really be the same capplet.
Comment 3 Michael Monreal 2007-01-21 16:04:23 UTC
In my current 2.17.x build the sound capplet has most (all?) of the multimedia system selector stuff build-in, so I guess we can forget about the multimedia system selector.
Comment 4 Bastien Nocera 2007-02-15 16:33:46 UTC
The Multimedia Selector shouldn't even have a .desktop. I filed bug 408292 about it.
Comment 5 Jakub Steiner 2007-02-16 14:31:07 UTC
As per results of #408292, closing as 'not a bug'.
Comment 6 Bastien Nocera 2007-02-16 14:46:37 UTC
Hmm, we removed the Multimedia Systems Selector from the menus, but does the Sound capplet have a new icon then?
Comment 7 Jakub Steiner 2007-02-16 15:03:40 UTC
I didn't realise there's two. The sound capplet is for configuring sounds for events only?
Comment 8 Bastien Nocera 2007-02-16 15:09:24 UTC
As well as which device is used for which function (ie. play movies on this device, etc.)
Comment 9 Andreas Nilsson 2007-02-16 15:32:28 UTC
Created attachment 82684 [details]
screenshot of the current capplet icon

Yes, the launcher is called gnome-sound-properties and looks like the attached image.
Comment 10 Martin Szulecki 2007-02-16 18:58:08 UTC
(In reply to comment #3)
> In my current 2.17.x build the sound capplet has most (all?) of the multimedia
> system selector stuff build-in, so I guess we can forget about the multimedia
> system selector.
> 

If you remove the multimedia system select capplet, please add a video capplet (since that is missing, like setup of a input device, selecting Xv adaptors, x/xv/SDL image output...).
Comment 11 Rodney Dawes 2007-02-16 20:23:08 UTC
(In reply to comment #10)
> If you remove the multimedia system select capplet, please add a video capplet
> (since that is missing, like setup of a input device, selecting Xv adaptors,
> x/xv/SDL image output...).

Any discussion on this matter belongs in a separate bug. The multimedia capplet was part of gnome-media anyway, and not gnome-control-center. Also see the recent "Removing the Multimedia Systems Selector from the menus" thread on desktop-devel-list for reasons for wanting to remove it.
Comment 12 Josef Vybíral 2007-02-17 20:42:44 UTC
Created attachment 82753 [details]
Tangoified gnome-sound-properties

Hi, find attached tangoified gnome-sound-properties icon. The archive contains all required sizes (with 48x48 as scalable). 
Cheers, cornelius
Comment 13 Josef Vybíral 2007-02-17 20:54:05 UTC
Created attachment 82758 [details]
I forgot to make 24x24 so here is the complete package
Comment 14 Josef Vybíral 2007-02-19 14:13:56 UTC
Created attachment 82886 [details]
gnome-sound-properties in gray

The colour of the reproductor has been changed on Jimmac's request to make it look more realistic.
Comment 15 Luca Ferretti 2007-02-22 13:51:08 UTC
(In reply to comment #14)
> Created an attachment (id=82886) [edit]
> gnome-sound-properties in gray
> 
> The colour of the reproductor has been changed on Jimmac's request to make it
> look more realistic.
> 

Good to me. Both the speaker and the floating note are well fitted to represent features of this capplet.

Can we commit on svn or are we blocked by some freeze?
Comment 16 Luca Ferretti 2007-02-22 13:54:16 UTC
Created attachment 83100 [details] [review]
Patch to use "gnome-sound-properties" named icon in .desktop file and in source

Here is the patch to use the name of the binary file as icon for Sound capplet (.desktop file and window icon).

Note that currenlty the .desktop file is named "gnome-settings-sound.desktop". Maybe we could rename it "gnome-sound-properties.desktop".
Comment 17 Lapo Calamandrei 2007-04-02 12:48:34 UTC
The icons looks great, any particular reason on why they are not in yet?
Comment 18 Jens Granseuer 2007-06-25 17:52:06 UTC
Don't we want a 48x48 png as well? Also, should we distribute all the sizes?
Comment 19 Michael Monreal 2007-06-25 18:24:21 UTC
No, the scalable icon targets 48x48, no need for a bitmap of this. 16x16, 22x22, 24x24 and 32x32 bitmap and the scalable version should be installed
Comment 20 Jens Granseuer 2007-06-25 18:34:39 UTC
I thought the idea was to not have to use svg. Anyway, what's with the gnome-settings-sound icon from gnome-icon-theme? Should these icons be added to the icon theme package or control-center? What's the reasoning here?
Comment 21 Michael Monreal 2007-06-25 18:45:35 UTC
Right, they should be in G-I-T as "preferences-desktop-sound" (and gnome-settings-sound a link to that) because they are in the naming spec. The tango reference theme for example also has that icon. Perhaps re-assign to gnome-icon-theme now?
Comment 22 Jens Granseuer 2007-06-25 18:48:29 UTC
Right away...
Comment 23 Jakub Steiner 2007-06-26 19:10:34 UTC
There is no preferences-desktop-sound in the latest naming spec - http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html. Please ship with the applet.
Comment 24 Michael Monreal 2007-06-26 19:19:21 UTC
CVS HEAD of icon-naming-utils still has it:

        <icon name="preferences-desktop-sound">
            <link>gnome-settings-sound</link>
            <link>knotify</link>
            <link>xfce4-sound</link>
        </icon>

and also tango-icon-theme ships this icon...
Comment 25 Jakub Steiner 2007-06-27 11:02:17 UTC
There have been a few icons in the naming spec that were removed over time. The naming spectriesto define a minimal set of icons that each icon theme authorshould aim to cover. The larger it is, the less likely it is theme authors will get full coverage. 

To be honest, the apps context is still huge and I don't even think it should be themeable. You're right about tango icon theme shiping a few icons that aren't defined in the naming spec. Nevertheless control center applets should ship their icon artwork.
Comment 26 Jens Granseuer 2007-06-28 18:00:17 UTC
Ok, committed. Thank you Josef, Luca.
I guess the old icon can be removed from g-i-t now.

2007-06-28  Jens Granseuer  <jensgr@gmx.net>

        Patch by: Luca Feretti <elle.uca@libero.it>

        * gnome-settings-sound.desktop.in.in:
        * sound-properties-capplet.c: (main): use new icon name (patch from bug
        #397305)

2007-06-28  Jens Granseuer  <jensgr@gmx.net>

        * Makefile.am:
        * icons/16x16/gnome-sound-properties.svg:
        * icons/22x22/gnome-sound-properties.svg:
        * icons/32x32/gnome-sound-properties.svg:
        * icons/scalable/gnome-sound-properties.svg:
        add new icons by Josef Vybí­ral (closes bug #397305)
Comment 27 Lapo Calamandrei 2007-06-28 20:50:38 UTC
Jens, looking at the attached changelog I think you included the svgs alone, for gnome-icon-theme we ship png for anything but the scalables, and in case of installation in the hicolor theme I think it's better to install the "scalable" in the 48x48 dir. If I'm wrong forgive me.
Comment 28 Jens Granseuer 2007-06-29 16:20:43 UTC
Nothing to forgive here. The prepare-ChangeLog script apparently didn't pick up the PNGs for some reason (and I blindly trusted it...), but there are in svn.

Just so I understand the rationale (the icon stuff is pretty alien to me): Why should the svg be installed in the 48x48 category?
Comment 29 Jaap A. Haitsma 2007-06-29 17:50:51 UTC
Jens, I think you did it right. gnome-icon-theme also does it the way you do it. AFAIK the SVG icons in scalable should be done on 48x48.

Can you also commit the tango icons in bug 399051 and bug 375230