After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 393599 - Previous and Next menus not active in a folder with *.ico files
Previous and Next menus not active in a folder with *.ico files
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 416230 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-06 17:20 UTC by Baptiste Mille-Mathias
Modified: 2010-07-10 04:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
trivial patch (320 bytes, patch)
2007-02-27 18:06 UTC, Felix Riemann
committed Details | Review

Description Baptiste Mille-Mathias 2007-01-06 17:20:28 UTC
Eos is able to open *.ico files but it disable the button in the toolbar "Previous" and Next", and the menus related to navigation in the pictures.
Comment 1 Claudio Saavedra 2007-01-15 03:25:15 UTC
Confirmed. Seems to be the same behavior than bug #364426. Probably related.
Comment 2 Felix Riemann 2007-02-27 18:01:33 UTC
The problem is a mime type mismatch.
Gnome-VFS reports image/x-ico for .ico files.
The gdk-pixbuf plugin only supports image/x-icon.

That way .ico files don't appear as valid items in the directory crawler (or even the thumbnailer).
As the normal loader works independent from the mime types it works if you load the files directly.

From a short search in the internet both mime types seem to be used.
So I guess the plugin should suppport both.

Moving this over to gdk-pixbuf.
Comment 3 Felix Riemann 2007-02-27 18:06:43 UTC
Created attachment 83482 [details] [review]
trivial patch

add image/x-ico to supported mime types
Comment 4 Matthias Clasen 2007-02-27 18:46:19 UTC
Looks fine, feel free to commit to both branches.
Comment 5 Felix Riemann 2007-02-27 19:33:29 UTC
Commited as rev. 17360 (gtk-2-10) and 17361 (trunk).
Comment 6 Felix Riemann 2007-03-09 10:44:14 UTC
*** Bug 416230 has been marked as a duplicate of this bug. ***